Page MenuHomeSolus

Update pytorch to 1.1.0
Needs ReviewPublic

Authored by xulongwu4 on May 4 2019, 12:43 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Summary

Update pytorch to 1.1.0 and add the C++ API.
Changelog is available here.

Test Plan
  • Verified the installation by executing the commands here.
  • Ran the MNIST example successfully.

Diff Detail

Repository
R4672 pytorch
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
xulongwu4 created this revision.May 4 2019, 12:43 PM
xulongwu4 requested review of this revision.May 4 2019, 12:43 PM
JoshStrobl requested changes to this revision.May 9 2019, 5:55 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
14

What is networking being turned on for?

61–63

Should be able to just do ln -sv $TORCH_PATH/bin/* $installdir/usr/bin/

65–67

See bin comment for likely more optimal method.

68–70

See bin comment for likely more optimal method.

71–73

See bin comment for likely more optimal method.

This revision now requires changes to proceed.May 9 2019, 5:55 PM
xulongwu4 marked an inline comment as done.May 10 2019, 10:38 AM
xulongwu4 added inline comments.
package.yml
14

When running the cmake configure step (invoked by the setup.py script), it will download a package named asmjit. This is what the network is for. One other choice is let the asmjit source code be another source in package.yml and specify its location before running setup.py.

xulongwu4 marked 2 inline comments as done.May 10 2019, 10:53 AM
xulongwu4 added inline comments.
package.yml
61–63

This does not seem a solution in this case. The packages are installed in $installdir/$TORCH_PATH/bin. So $TORCH_PATH/bin/* will just be empty in my opinion.

xulongwu4 marked an inline comment as done.May 13 2019, 4:19 PM
xulongwu4 marked 3 inline comments as done.May 13 2019, 4:22 PM
xulongwu4 added inline comments.
package.yml
65–67

See comments above.

68–70

See comments above.

71–73

See comments above.

xulongwu4 marked 7 inline comments as done.May 13 2019, 4:22 PM
xulongwu4 marked an inline comment as done.

@JoshStrobl Do you have time to take another look at this patch?

In the future, please use the Add Action functionality to request review again. That way it won't sit at the bottom of the list with awaiting authors.

package.yml
14

I would much rather it be another dependency if possible.

xulongwu4 updated this revision to Diff 15882.Fri, Jun 28, 5:02 PM

Disable networking.

xulongwu4 marked an inline comment as done.Fri, Jun 28, 5:03 PM