Submitting Qogir-theme package for review
Details
Details
Diff Detail
Diff Detail
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
Event Timeline
Comment Actions
Additionally, all the AUTHORS and COPYING files can be removed. We already indicate what the license is in the package information via the ypkg license key.
| package.yml | ||
|---|---|---|
| 1 | Should be all lowercase. | |
| 15 | Should be using install not mkdir | |
| pspec_x86_64.xml | ||
| 24–68 | We don't support Cinnamon. This can be removed. | |
| 752–796 | We don't support Cinnamon. This can be removed. | |
| 1482–1526 | We don't support Cinnamon. This can be removed. | |
| 2940–2984 | We don't support Cinnamon. This can be removed. | |
| 3670–3714 | We don't support Cinnamon. This can be removed. | |
Comment Actions
This isn't a task, this is a differential patch. You need to supply a patch and ensure it addresses the issues I raised in this one.