Page MenuHomeSolus

The inclusion of Qogir-theme fixes T7523
AbandonedPublic

Authored by zerocon on May 4 2019, 6:39 AM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Summary

Submitting Qogir-theme package for review

Test Plan

Tested on Budgie

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
zerocon created this revision.May 4 2019, 6:39 AM
zerocon requested review of this revision.May 4 2019, 6:39 AM
zerocon updated this revision to Diff 14928.May 4 2019, 6:43 AM
zerocon edited the test plan for this revision. (Show Details)

The inclusion of Qogir-theme fixes T7523

JoshStrobl requested changes to this revision.May 10 2019, 4:48 PM
JoshStrobl added a subscriber: JoshStrobl.

Additionally, all the AUTHORS and COPYING files can be removed. We already indicate what the license is in the package information via the ypkg license key.

package.yml
1

Should be all lowercase.

15

Should be using install not mkdir

pspec_x86_64.xml
24–68

We don't support Cinnamon. This can be removed.

752–796

We don't support Cinnamon. This can be removed.

1482–1526

We don't support Cinnamon. This can be removed.

2940–2984

We don't support Cinnamon. This can be removed.

3670–3714

We don't support Cinnamon. This can be removed.

This revision now requires changes to proceed.May 10 2019, 4:48 PM
JoshStrobl abandoned this revision.May 27 2019, 11:31 AM

Closing due to lack of response.

algent added a subscriber: algent.Jun 5 2019, 2:57 PM

Is it possible to reopen this again. I can maintain this package.

Is it possible to reopen this again. I can maintain this package.

This isn't a task, this is a differential patch. You need to supply a patch and ensure it addresses the issues I raised in this one.