Initial version of budgie-extras
Resolves T7857
Details
Details
- Reviewers
JoshStrobl - Group Reviewers
Triage Team - Maniphest Tasks
- T7857: Ubuntu Budgie Extras - Applets
- Successfully build common "languages".
- Successfully build quicknote applet.
- Successfully build kangaroo applet.
- Successfully build weathershow applet.
- Install/uninstall process of eath applet.
- In weathershow applet, choosed different places with traybar on/off and desktop option on/off.
- In kangaroo applet, run files from the applet without problems.
- In quicknote applet, add/remove notes with no problems.
Diff Detail
Diff Detail
- Branch
- arcpatch-D6178
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
That isn't how you do prefixed patterns, look at the Vala example I gave in the respective patch. Furthermore your descriptions need to be a list instead of a text block, stop text wrapping in your editor and do not use 80col, you're creating linebreaks where they shouldn't be.
This comment was removed by Christoph3.
Comment Actions
Applet names should follow the naming scheme of budgie-name-applet, such as budgie-quicknote-applet
budgie.desktop is not a valid component. Should be desktop.budgie
| package.yml | ||
|---|---|---|
| 8 | Invalid component. | |
| 9 | Applet names should follow the naming scheme of budgie-name-applet, such as budgie-quicknote-applet | |
| 13 | Should be: budgie-extras is a translations file package required by various third-party applets. | |
| 14 | Should not start with "is an". Should be "Quicknote is an applet"... | |
| 15 | Random reference to a task that should be removed. & should be replaced with and | |
| 18 | Should be: budgie-extras is a translations file package required by various third-party applets. | |
| 19 | Should not start with "is an". Should be "Quicknote is an applet"... | |
| 20 | & should be replaced with and | |
| 24 | Should be able to just do /usr/lib64/budgie-desktop/plugins/budgie-quicknote | |
| 28 | Should be able to just do /usr/lib64/budgie-desktop/plugins/budgie-kangaroo | |
| 31 | Should be able to just do /usr/lib64/budgie-desktop/plugins/budgie-weathershow | |
| 32 | Not necessary. | |
| 39 | Not necessary, check the dependency of libgee-devel | |
| 40 | Not necessary, you already specified the one for budgie. Check the dependencies of budgie-desktop-devel | |
| 42 | Not necessary, you already specified the one for budgie. Check the dependencies of budgie-desktop-devel | |
Comment Actions
Updated package.yml
- Insert Josh corrections in package.yml
- Libgee-devel needed in meson.buil from weathershow-applet
Comment Actions
Not really sure what you're changing, but look at my original remarks about your builddeps. You're not fixing anything.
Comment Actions
Hi there, I dont know if there is any problem with dev.getsol but i wrote comments on each builddep i couldnt remove some build-deps from the package.yml because it was giving error while compiling.
Libgee-devel: Error while compiling without it: Dependency gee-0.8 found: NO (tried pkgconfig and cmake)
budgie-weathershow/src/weathershow/meson.build:20:0: ERROR: Dependency "gee-0.8" not found
Json-glib: Dependency json-glib-1.0 found: NO (tried pkgconfig and cmake)
budgie-weathershow/src/weathershow/meson.build:20:0: ERROR: Dependency "json-glib-1.0" not found, tried pkgconfig and cmake
libsoup: Dependency libsoup-2.4 found: NO (tried pkgconfig and cmake)
budgie-weathershow/src/weathershow/meson.build:20:0: ERROR: Dependency "libsoup-2.4" not found, tried pkgconfig and cmake
The only two changes i made in this package.yml was removing /usr/share/glib-2.0/schemas/org.ubuntubudgie.plugins.weathershow.gschema.xml as you stated and removed buildep libpeas.
| package.yml | ||
|---|---|---|
| 39 | Libgee-devel needed in meson.build from weathershow-applet: Error while compiling without it: Dependency gee-0.8 found: NO (tried pkgconfig and cmake) budgie-weathershow/src/weathershow/meson.build:20:0: ERROR: Dependency "gee-0.8" not found | |
| 40 | Dependency json-glib-1.0 found: NO (tried pkgconfig and cmake) budgie-weathershow/src/weathershow/meson.build:20:0: ERROR: Dependency "json-glib-1.0" not found, tried pkgconfig and cmake | |
| 42 | Dependency libsoup-2.4 found: NO (tried pkgconfig and cmake) budgie-weathershow/src/weathershow/meson.build:20:0: ERROR: Dependency "libsoup-2.4" not found, tried pkgconfig and cmake | |
Comment Actions
- I never stated to remove gee, I stated to remove libsoup because it is a dependency of gee.
- I also never stated to remove json-glib's pkgconfig, I stated to remove the libpeas pkgconfig because it is a dependency of budgie-desktop-devel.
I'm going to mark this as abandoned because of the amount of review comments that are clearly causing some confusion. Please re-submit once you've cleaned up the builddeps.