Paths

Table of Contentst

Differential D6092

Update python-sip to 4.19.16
ClosedPublic
Actions

Authored by kyrios123 on Apr 22 2019, 8:07 AM.

Tags

None

Referenced Files

	F11032869: D6092.id.diff
	Wed, Aug 9, 2:51 PM

	F11032867: D6092.id14658.diff
	Wed, Aug 9, 2:51 PM

	F11032866: D6092.id14829.diff
	Wed, Aug 9, 2:51 PM

	F11032865: D6092.id14870.diff
	Wed, Aug 9, 2:51 PM

	F11032864: D6092.id14957.diff
	Wed, Aug 9, 2:51 PM

	F11025929: D6092.diff
	Wed, Aug 9, 1:33 AM

	F10988870: D6092.id14829.diff
	Mon, Jul 24, 12:52 PM

	F10921848: D6092.id14870.diff
	Jul 9 2023, 3:18 PM

View All 19 Files

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T7647: puddletag breaks when python-sip configured with --sip-module PyQt5.sip

Commits

R2693:7a54f7d222ca: Update python-sip to 4.19.16

Summary

Changelog:

The reference count displayed by sip.dump() now has the same caveat as sys.getrefcount().
Added SIP_NULLPTR to the public API.
Added support for size_t.
Added sipLong_AsSizeT() to the C API.
Added the '=' format characters to sipBuildResult() and sipParseResult().
Bug fixes.

Fixes T7647

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

Successfully build python3-qt5 against this package (it fails with the version that is currently in the repo)
Successfully build openshot-qt against this package
cura doesn't throw ValueError: PyCapsule_GetPointer called with incorrect name anymore

Diff Detail

Repository

R2693 python-sip

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kyrios123 created this revision.Apr 22 2019, 8:07 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptApr 22 2019, 8:07 AM

kyrios123 requested review of this revision.Apr 22 2019, 8:07 AM

kyrios123 added a comment.Apr 22 2019, 8:08 AM

This comment was removed by kyrios123.

kyrios123 edited the test plan for this revision. (Show Details)Apr 22 2019, 9:05 AM

kyrios123 mentioned this in D5624: Update python-qt5 to 5.12.1.Apr 22 2019, 4:38 PM

kyrios123 mentioned this in D5625: Update python3-qt5 to 5.12.1.

kyrios123 edited the test plan for this revision. (Show Details)Apr 22 2019, 7:14 PM

BridouZ added a child revision: D5625: Update python3-qt5 to 5.12.1.Apr 23 2019, 10:55 AM

kyrios123 mentioned this in D6099: Update cura to 4.0.0.Apr 27 2019, 1:46 PM

Once above mentioned items have addressed, feel free to push.

package.yml
13	Should consider updating the summaries to have: python-sip: A tool that creates python 2 bindings for C and C++ libraries python3-sip: A tool that creates python3 bindings for C and C++ libraries
27–28	Should go after ^python3-sip

This revision now requires changes to proceed.Apr 29 2019, 7:05 PM

Address remarks

JoshStrobl requested changes to this revision.Apr 30 2019, 12:22 PM

JoshStrobl added inline comments.

package.yml
13	Shouldn't that be "python3-sip is a tool"?

This revision now requires changes to proceed.Apr 30 2019, 12:22 PM

python3-sip
python3-sip
python3-sip
...
python3-sip

Macro itshappening:

This revision is now accepted and ready to land.Apr 30 2019, 7:26 PM

landing this because I need it for QT update :)

Closed by commit R2693:7a54f7d222ca: Update python-sip to 4.19.16 (authored by kyrios123, committed by Girtablulu). · Explain WhyMay 7 2019, 2:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

67 lines

pspec_x86_64.xml

45 lines

Diff 14658

package.yml

Loading...

pspec_x86_64.xml

Loading...