Page MenuHomeSolus

Update python-sip to 4.19.16
ClosedPublic

Authored by kyrios123 on Apr 22 2019, 8:07 AM.

Details

Summary

Changelog:

  • The reference count displayed by sip.dump() now has the same caveat as sys.getrefcount().
  • Added SIP_NULLPTR to the public API.
  • Added support for size_t.
  • Added sipLong_AsSizeT() to the C API.
  • Added the '=' format characters to sipBuildResult() and sipParseResult().
  • Bug fixes.

Fixes T7647

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan
  • Successfully build python3-qt5 against this package (it fails with the version that is currently in the repo)
  • Successfully build openshot-qt against this package
  • cura doesn't throw ValueError: PyCapsule_GetPointer called with incorrect name anymore

Diff Detail

Repository
R2693 python-sip
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
kyrios123 created this revision.Apr 22 2019, 8:07 AM
kyrios123 requested review of this revision.Apr 22 2019, 8:07 AM
This comment was removed by kyrios123.
kyrios123 edited the test plan for this revision. (Show Details)Apr 22 2019, 9:05 AM
kyrios123 edited the test plan for this revision. (Show Details)Apr 22 2019, 7:14 PM
JoshStrobl requested changes to this revision.Apr 29 2019, 7:05 PM
JoshStrobl added a subscriber: JoshStrobl.

Once above mentioned items have addressed, feel free to push.

package.yml
13

Should consider updating the summaries to have:

python-sip: A tool that creates python 2 bindings for C and C++ libraries
python3-sip: A tool that creates python3 bindings for C and C++ libraries

27–28

Should go after ^python3-sip

This revision now requires changes to proceed.Apr 29 2019, 7:05 PM
kyrios123 updated this revision to Diff 14829.Apr 29 2019, 7:41 PM
kyrios123 edited the test plan for this revision. (Show Details)

Address remarks

JoshStrobl requested changes to this revision.Apr 30 2019, 12:22 PM
JoshStrobl added inline comments.
package.yml
13

Shouldn't that be "python3-sip is a tool"?

This revision now requires changes to proceed.Apr 30 2019, 12:22 PM
kyrios123 updated this revision to Diff 14870.Apr 30 2019, 6:26 PM

python3-sip
python3-sip
python3-sip
...
python3-sip

This revision is now accepted and ready to land.Apr 30 2019, 7:26 PM

landing this because I need it for QT update :)

This revision was automatically updated to reflect the committed changes.