Page MenuHomeSolus

Initial commit of netcdf
Needs ReviewPublic

Authored by kaveiros on Apr 16 2019, 9:46 PM.

Details

Reviewers
None
Group Reviewers
Triage Team
Summary

Initial commit of netcdf

Test Plan

make check is ran after make install

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
kaveiros created this revision.Apr 16 2019, 9:46 PM
kaveiros requested review of this revision.Apr 16 2019, 9:46 PM

Apart from the many errors in package.yml, and your insufficient test plan, there has been no package request for netcdf yet. Why did you push this? In fact, as per our policy:

Prior to submitting a patch, please ensure you are checking the following:

  • There is not an existing patch already provided by others.
  • If you are submitting a patch for the inclusion of software in the repo, that the package your patch pertains to has a corresponding package request that is accepted for inclusion or is a dependency of a package that has been accepted into the repository.

It is a prerequisite for Generic Mapping Tools package. Netcdf needs to be installed first along with Gdal package which already exists. It is my first packaging attempt. Could you please help me fix errors?

Alright! :)
Regarding your test plan: units test are cool, but they shouldn't be the whole test plan. Just manually perform some operations with your package or try to build Generic Mapping Tools against netcdf-c and make sure it works.
And finally, patch's title should match the package name, so in in this case it misses -c.

package.yml
6

License must be a SPDX-3.0 identifier. Here's a list: https://spdx.org/licenses. You don't the full license body.

9

The summary is longish. Just write a simple phrase: that's what users get first when they read at a package search list with eopkg.

13

Use 4-space indentation.

pspec_x86_64.xml
52

There's a static library and we usually don't allow them in packages. In general, passing --disable-static to %configure solves it.

Thank you for your suggestions! I ll make the changes you propose, try the suggested test and will recommit. :)