Page MenuHomeSolus

Update python-qtpy to 1.7.0
ClosedPublic

Authored by Jacalz on Apr 16 2019, 7:03 AM.

Details

Summary

Full changelog can be found here.

Test Plan
  • Installed and verified that onionshare still worked as expected

Diff Detail

Repository
R3732 python-qtpy
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Jacalz created this revision.Apr 16 2019, 7:03 AM
Jacalz requested review of this revision.Apr 16 2019, 7:03 AM
Jacalz added a subscriber: kyrios123.EditedApr 16 2019, 7:04 AM

Do we know if there are any packages that rely on the Python 2.7 support in this? Otherwise I would be glad to drop it and stick with Python 3. @kyrios123

In D6024#95221, @Jacalz wrote:

Do we know if there are any packages that rely on the Python 2.7 support in this? Otherwise I would be glad to drop it and stick with Python 3. @kyrios123

I usually do a eopkg info python-qtpy to see the reverse dependencies to have a clue, but this won't cover everything.
Ideally you should grep the repositories to find were it is used but for that you should have cloned all the repositories.

In D6024#95221, @Jacalz wrote:

Do we know if there are any packages that rely on the Python 2.7 support in this? Otherwise I would be glad to drop it and stick with Python 3. @kyrios123

I usually do a eopkg info python-qtpy to see the reverse dependencies to have a clue, but this won't cover everything.
Ideally you should grep the repositories to find were it is used but for that you should have cloned all the repositories.

Okay, thanks for the info. Will keep it as is until the mass deprecation of Python2.

I’m not entirely sure about this, but Spyder (Python2 version) might be the only package relying up on the python 2 support of this package. This package was included in 2017 to the repo in order to satisfy Spyder based on Python 2. I’d vote for dropping Spyder and flicking off python 2 support in this if we can...

spyder2 is a popular development environment for python2. As long as python 2 remains, it makes sense to keep it (just my opinion)

DataDrake accepted this revision.May 16 2019, 10:52 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.May 16 2019, 10:52 PM
This revision was automatically updated to reflect the committed changes.