Updated to version 0.8.2
Details
Diff Detail
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
I packaged qomui to the newest version. My first real package, so any feedback would be appreciated.
Thanks for this patch submission ! ?
Here is the feedback... don't worry if there are many things, it's your first submission so it's normal.
Here you did create the package as a new package instead of updating the existing one.
First clone the existing qomi package : git clone https://dev.getsol.us/source/qomui.git at the same place you set the qomi package you did. Then you update it just like you did.
Your commit title Updated to version 0.8.2 should be instead of Second commit of qomui.
The summary should be a summarized changelog or eventually a link to the original changelog if too long. Link format should be [description](url)
You should also tell that your patches resolves or fixes T7362, in your commit message, this way the system will link it to the task and do whatever needs to be done (like closing the task when the patch is landed for example)
Your test plan should be a little more detailed
| package.yml | ||
|---|---|---|
| 6 | ||
| 10 | The previous description was better imho | |
| 15 | This is the python 2 version of the package and you're building against python 3. | |
| 20 | This package has never been required and was a mistake of the original packager. | |
| 22 | Are you sure this is actually required (it's a question) ? | |
| 24 | Empty sections should be removed | |