Page MenuHomeSolus

Second commit of qomui
AbandonedPublic

Authored by gaagaard on Apr 15 2019, 8:45 PM.
Tags
None
Referenced Files
F11055132: D6022.diff
Fri, Aug 11, 1:30 AM
F10875556: D6022.id14538.diff
Jun 20 2023, 6:17 AM
F10815384: D6022.id14538.diff
May 31 2023, 8:16 PM
F10814530: D6022.diff
May 31 2023, 4:16 PM
F10779724: D6022.id.diff
May 24 2023, 7:47 PM
F10770346: D6022.id14538.diff
May 20 2023, 11:09 PM
F10762267: D6022.diff
May 18 2023, 4:09 PM

Details

Reviewers
None
Group Reviewers
Triage Team
Summary

Updated to version 0.8.2

Test Plan

Tested my own openVPN config

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

I packaged qomui to the newest version. My first real package, so any feedback would be appreciated.

Thanks for this patch submission ! ?

Here is the feedback... don't worry if there are many things, it's your first submission so it's normal.

Here you did create the package as a new package instead of updating the existing one.
First clone the existing qomi package : git clone https://dev.getsol.us/source/qomui.git at the same place you set the qomi package you did. Then you update it just like you did.

Your commit title Updated to version 0.8.2 should be instead of Second commit of qomui.
The summary should be a summarized changelog or eventually a link to the original changelog if too long. Link format should be [description](url)

You should also tell that your patches resolves or fixes T7362, in your commit message, this way the system will link it to the task and do whatever needs to be done (like closing the task when the patch is landed for example)

Your test plan should be a little more detailed

package.yml
6

Should use SPDX 3.x license identifier. More info here

10
15

This is the python 2 version of the package and you're building against python 3.
You should use python3-dbus

20

This package has never been required and was a mistake of the original packager.
python3-qt5 however is needed and missing here

22

Are you sure this is actually required (it's a question) ?
I saw everyone adding it but I haven't found where/why it would be needed.

24

Empty sections should be removed

DataDrake added a subscriber: DataDrake.

Closing due to lack of movement for 30 days.