Page MenuHomeSolus

Add missing rundeps, fixes T7669
ClosedPublic

Authored by Jacalz on Apr 14 2019, 4:45 PM.

Details

Summary

Since the last update it looks like it needed a couple dependencies to work properly. Those deps were already installed on my machine so it worked for me but not other people.
Fixes T7669

Test Plan
  • Install and connect to tor network

Diff Detail

Repository
R4470 onionshare
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Jacalz created this revision.Apr 14 2019, 4:45 PM
Jacalz requested review of this revision.Apr 14 2019, 4:45 PM
JoshStrobl requested changes to this revision.Apr 16 2019, 2:58 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
23–24

Let's clean this up while we're at it. Should be -Dm00644 and no quotes around target path.

This revision now requires changes to proceed.Apr 16 2019, 2:58 PM
Jacalz updated this revision to Diff 14552.Apr 16 2019, 3:56 PM

Adress review comments

You might need to do some cleaning of this repo or something along those lines because solbuild complains about some history.xml file with invalid yml. It builds fine if I move the files to a different folder. Anyhow, review comments are addressed...

DataDrake accepted this revision.May 20 2019, 10:55 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2019, 10:56 PM
Closed by commit R4470:d28a72d18382: Add missing rundeps, fixes T7669 (authored by Jacalz, committed by DataDrake). · Explain Why
This revision was automatically updated to reflect the committed changes.