Paths

Table of Contentst

Differential D599

Add keybase
AbandonedPublic
Actions

Authored by Tebro on Jul 13 2017, 1:47 PM.

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Summary

This is the full package, containing the basic keybase client, and the kbfs parts.

KBFS is currently experimental, and it is not versioned, meaning one has to find a commit that works with client releases.

For this first package iteration this was done with the help of the Keybase developers.

Fixes: T1132

Test Plan

Run it, login, verify that things work.

Diff Detail

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

Tebro created this revision.Jul 13 2017, 1:47 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJul 13 2017, 1:47 PM

Tweaked description

JoshStrobl requested changes to this revision.Jul 13 2017, 4:59 PM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

files/keybase.tmpfiles
2	Unless absolutely unavoidable, using 777 should not be used, as I stated on IRC.
package.yml
16–41	A multitude of these are redundant and are dependencies of other packages. Please look your packages and clean the builddeps up.
57	`/opt` is not an acceptable location. Use `/usr/share/keybase` and clean up files like the post_install script.

This revision now requires changes to proceed.Jul 13 2017, 4:59 PM

Fixed issues

Tebro added inline comments.Jul 14 2017, 10:11 AM

files/keybase.tmpfiles
2	This is the mount point for kbfs, not quite sure how else we can allow any user to mount to it.

The package is updated for the following points:

Now installed under /usr/share/keybase instead of /opt/keybase
Cleaned up the buildeps list

The 777 mountpoint issue still stand, if someone has an idea on how we can work around it that would be great.

Bringing @ikey in to get his opinion / thoughts on the permission bit.

Tebro marked 2 inline comments as done.Jul 20 2017, 7:15 AM

ylk added a subscriber: ylk.Jul 30 2017, 9:14 AM

silke added a subscriber: silke.Aug 28 2017, 1:16 PM

andyisageek added a subscriber: andyisageek.Sep 23 2017, 12:32 AM

• userdisabled20062021 added a subscriber: • userdisabled20062021.Oct 5 2017, 12:13 PM

GotExx added a subscriber: GotExx.Oct 9 2017, 3:24 PM

@JoshStrobl Keybase uses 777 by Default.

https://github.com/keybase/client/issues/5120#issuecomment-267472028

funnylookinhat added a subscriber: funnylookinhat.Oct 27 2017, 3:28 PM

Any updates about this?

SinaCutie added a subscriber: SinaCutie.Nov 20 2017, 6:29 PM

In D599#22654, @baimafeima wrote:

Any updates about this?

I'm wondering the same thing. Are we close to seeing this show up in one of the repos?

Unknown Object (User) added a subscriber: Unknown Object (User).Dec 19 2017, 2:44 AM

bgta added a subscriber: bgta.Jan 14 2018, 7:38 AM

xulongwu4 added a subscriber: xulongwu4.Jan 17 2018, 9:07 PM

tjgillies added a subscriber: tjgillies.Feb 13 2018, 5:40 AM

raindev added a subscriber: raindev.Feb 17 2018, 1:53 PM

KBFS v1.0.47 now mounts KBFS in /run/user/$UID/keybase/kbfs. It also includes keybase-redirector, which ensures that /keybase/{private,public,team} point to the /run/user folder. The permissions for /keybase can be set to 0755, but keybase-redirector requires SUID.

Additionally, it is now possible to set KEYBASE_SKIP_32_BIT=1 to skip the creation of 32-bit binaries.

See: https://gist.github.com/silkeh/338e1104d3d19b4ff547aab9f7f6e851

raindev removed a subscriber: raindev.May 7 2018, 8:48 PM

doubledup added a subscriber: doubledup.May 21 2018, 7:45 PM

Snuggle awarded a token.Jun 10 2018, 10:47 AM

Snuggle added a subscriber: Snuggle.

@Tebro This differential doesn't build successfully in solbuild. Is this a new issue?

https://pastebin.com/bJsqAF07

silke mentioned this in D3305: Initial packaging of Keybase Client v2.3.0.Jul 16 2018, 3:55 PM