Page MenuHomeSolus

Add keybase
AbandonedPublic

Authored by Tebro on Jul 13 2017, 1:47 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Summary

This is the full package, containing the basic keybase client, and the kbfs parts.

KBFS is currently experimental, and it is not versioned, meaning one has to find a commit that works with client releases.

For this first package iteration this was done with the help of the Keybase developers.

Fixes: T1132

Test Plan

Run it, login, verify that things work.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Tebro created this revision.Jul 13 2017, 1:47 PM
Tebro updated this revision to Diff 1286.Jul 13 2017, 2:12 PM
Tebro retitled this revision from Add keybase to repos to Add keybase.
Tebro edited the summary of this revision. (Show Details)

Tweaked description

JoshStrobl requested changes to this revision.Jul 13 2017, 4:59 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
files/keybase.tmpfiles
2

Unless absolutely unavoidable, using 777 should not be used, as I stated on IRC.

package.yml
16–41

A multitude of these are redundant and are dependencies of other packages. Please look your packages and clean the builddeps up.

57

/opt is not an acceptable location. Use /usr/share/keybase and clean up files like the post_install script.

This revision now requires changes to proceed.Jul 13 2017, 4:59 PM
Tebro updated this revision to Diff 1292.Jul 13 2017, 7:11 PM
Tebro edited edge metadata.

Fixed issues

Tebro added inline comments.Jul 14 2017, 10:11 AM
files/keybase.tmpfiles
2

This is the mount point for kbfs, not quite sure how else we can allow any user to mount to it.

The package is updated for the following points:

  • Now installed under /usr/share/keybase instead of /opt/keybase
  • Cleaned up the buildeps list

The 777 mountpoint issue still stand, if someone has an idea on how we can work around it that would be great.

Bringing @ikey in to get his opinion / thoughts on the permission bit.

Tebro marked 2 inline comments as done.Jul 20 2017, 7:15 AM
ylk added a subscriber: ylk.Jul 30 2017, 9:14 AM
silke added a subscriber: silke.Aug 28 2017, 1:16 PM
GotExx added a subscriber: GotExx.Oct 9 2017, 3:24 PM

Any updates about this?

Any updates about this?

I'm wondering the same thing. Are we close to seeing this show up in one of the repos?

bgta added a subscriber: bgta.Jan 14 2018, 7:38 AM
silke added a comment.May 7 2018, 8:41 PM

KBFS v1.0.47 now mounts KBFS in /run/user/$UID/keybase/kbfs. It also includes keybase-redirector, which ensures that /keybase/{private,public,team} point to the /run/user folder. The permissions for /keybase can be set to 0755, but keybase-redirector requires SUID.

Additionally, it is now possible to set KEYBASE_SKIP_32_BIT=1 to skip the creation of 32-bit binaries.

See: https://gist.github.com/silkeh/338e1104d3d19b4ff547aab9f7f6e851

raindev removed a subscriber: raindev.May 7 2018, 8:48 PM
Snuggle added a subscriber: Snuggle.

@Tebro This differential doesn't build successfully in solbuild. Is this a new issue?

https://pastebin.com/bJsqAF07

DataDrake abandoned this revision.Aug 18 2018, 10:02 PM
DataDrake added a subscriber: DataDrake.

Closing due to lack of movement.