Page MenuHomeSolus

Update kodi-pvr-ipsimple to 3.5.3 and backport patches
AbandonedPublic

Authored by Jacalz on Apr 13 2019, 9:05 AM.

Details

Reviewers
None
Group Reviewers
Triage Team
Maniphest Tasks
T7850: update kodi-pvr-iptvsimple to 4.0
Summary

Summarized Changelog:

  • Add support for Kodi 18 Leia.
  • Fixed multithreading issues.
  • Add support for #EXT-X-PLAYLIST-TYPE in M3U.
  • Language updates from Transifex.
  • Updates to PVR addon API.
  • Removal of never used addon interface functions.
  • Change line lenght to 4k.

Fixes T7850

Test Plan
  • Enable in Kodi, add some channels and view some tv-programs.

Diff Detail

Repository
R4403 kodi-pvr-iptvsimple
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Jacalz created this revision.Apr 13 2019, 9:05 AM
Jacalz requested review of this revision.Apr 13 2019, 9:05 AM

This was the last version with rapidxml (DOA since 2009) packaged bundled and further versions didn't have much new stuff. Thus I choose to use this version and backport two patches.

Ping @ermo as kodi maintainer

ermo added a comment.EditedApr 13 2019, 9:42 AM

@Jacalz

Cheers for adding this.

However, my goal is to include all offical binary add-ons in a single package. Currently they're included in kodi proper, but I'm beginning to think this is the wrong approach.

It also doesn't seem as if iptvsimple is included in my "batteries included" build of kodi, even if I expected it to be.

Not sure what is going on -- perhaps the problem is that the upstream add-on needs a bit of TLC akin to the work you just put in?

Is there any chance you could try to engage with upstream on this? This would benefit *all* kodi consumers, not just Solus. =)

I don’t really know either to be quite honest and I don’t really know where to send it to. Or in general how Kodi addons are packaged. I think that’s a task better left to the Kodi maintainer. I’m sorry 😐

Do you want me to close this? @ermo

ermo added a comment.EditedJun 19 2019, 7:56 PM

@Jacalz

I appreciate you taking the time to make this work yourself. I'm a bit burnt out at the moment so not a lot of packaging happening from my side these days.

You should probably update the title of the diff to 4.0 instead of 3.5.3 if you can?

In D5986#103200, @ermo wrote:

@Jacalz

I appreciate you taking the time to make this work yourself. I'm a bit burnt out at the moment so not a lot of packaging happening from my side these days.

You should probably update the title of the diff to 4.0 instead of 3.5.3 if you can?

I technically can but it requires packaging a dependency that’s not really developed any more. It is probably the best way to do it so I better get it done.

Jacalz abandoned this revision.Jul 2 2019, 2:46 PM

Everything seems to work in 18.3 version of KODI 👍