Update avahi to 0.7 and convert to package.yml
ClosedPublic
Actions

Authored by kyrios123 on Jul 12 2017, 4:09 PM.

Details

Reviewers

ikey

Group Reviewers

Triage Team

Commits

R412:22a2048a5e21: Update avahi to 0.7 and convert to package.yml

Summary

The Avahi 0.7 release brings two new features, binary TXT records in XML service files and the ability to start the gobject client in a custom context.

Notable Changes:

avahi-daemon: Remove all default rlimits from avahi-daemon.conf, as two main problems happened with firstly rlimit-nproc causing avahi to fail when started in a container without user namespaces and secondly because memory rlimits were causing avahi to crash in some cases. Leave it up to the init system to impose any modified limits instead. It is recommend to ship this change in distribution default config files.
avahi-common: Fix watch cleanup issue in watch_free
avahi-autoipd: clear previously set address before binding a new one
avahi-autoipd: fix dhclient hooks to check for avahi-autoipd before running
build: Move default rundir from /var/run to /run as per modern system setups

Full release notes available here

Packaging:

convert to ypkg
fix avahi-daemon home directory
create avahi-autoipd user & group
add gdbm-devel build dependency
specify with-avahi-priv-access-group as the default group does not exists

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

run avahi-daemon

$ sudo avahi-daemon 
Password: 
Found user 'avahi' (UID 84) and group 'avahi' (GID 84).
Successfully dropped root privileges.
avahi-daemon 0.7 starting up.
WARNING: No NSS support for mDNS detected, consider installing nss-mdns!
Loading service file /etc/avahi/services/sftp-ssh.service.
Loading service file /etc/avahi/services/ssh.service.
Joining mDNS multicast group on interface enp0s3.IPv6 with address fe80::b342:3dca:8294:a26d.
New relevant interface enp0s3.IPv6 for mDNS.
Joining mDNS multicast group on interface enp0s3.IPv4 with address 10.0.2.15.
New relevant interface enp0s3.IPv4 for mDNS.
Network interface enumeration completed.
Registering new address record for fe80::b342:3dca:8294:a26d on enp0s3.*.
Registering new address record for 10.0.2.15 on enp0s3.IPv4.
Server startup complete. Host name is solus-budgie.local. Local service cookie is 3307683534.
Service "solus-budgie" (/etc/avahi/services/ssh.service) successfully established.
Service "solus-budgie" (/etc/avahi/services/sftp-ssh.service) successfully established.

run avahi-browse --all

$ avahi-browse --all
+ enp0s3 IPv6 solus-budgie                                  _ssh._tcp            local
+ enp0s3 IPv4 solus-budgie                                  _ssh._tcp            local
+ enp0s3 IPv6 solus-budgie                                  _sftp-ssh._tcp       local
+ enp0s3 IPv4 solus-budgie                                  _sftp-ssh._tcp       local

Everything looks normal.

Diff Detail

Repository

R412 avahi

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kyrios123 created this revision.Jul 12 2017, 4:09 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJul 12 2017, 4:10 PM

It can be converted as comar (though we don't always rush the conversion depending on what it is) is just creating/removing user and group (as per your sysusers/tmpfiles). But yeah, testing conversions usually needs to be robust in case files end up in different locations and making sure it builds/works the same etc

package.yml
40	Let's use %libdir% here too

Add: test plan

In D595#8502, @sunnyflunk wrote:

It can be converted as comar (though we don't always rush the conversion depending on what it is) is just creating/removing user and group (as per your sysusers/tmpfiles). But yeah, testing conversions usually needs to be robust in case files end up in different locations and making sure it builds/works the same etc

I know that not everything can be converted, that's why I asked. I did it because it's a good exercise for me as it allows me to learn new things and get some interesting feedback :)
A few locations have been changed

some /usr/lib -> /usr/lib64
/var/run -> /run (see summary). I have taken this into account (+ it shouldn't really be a problem as /var/run is a symbolic link to /run in Solus).

I have carefully compared the behavior with the old version 0.6.32/comar and I got the same results so I think it should be fine !

kyrios123 mentioned this in T3933: Package request: nss-mdns.Jul 19 2017, 3:34 PM