Page MenuHomeSolus

Update Platformio to version 3.6.6, resolves T7820
ClosedPublic

Authored by Christoph3 on Apr 6 2019, 8:59 PM.

Details

Summary

Fixed bugs:

-Project Generator: fixed a warning "Property !!! WARNING !!! is not allowed" for VSCode.
-Fixed an issue when PlatformIO Build System does not pick up "mbed_lib.json" files from libraries.
-Fixed an error with conflicting declaration of a prototype (Arduino sketch preprocessor).
-Fixed "FileExistsError" when platformio ci command is used in pair with --keep-build-dir option.
-Fixed an issue with incorrect order of project "include" and "src" paths in CPPPATH.
Test Plan

Installed and started without errors/problems

Diff Detail

Repository
R2449 platformio
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Christoph3 created this revision.Apr 6 2019, 8:59 PM
Christoph3 requested review of this revision.Apr 6 2019, 8:59 PM
Girtablulu requested changes to this revision.Apr 7 2019, 4:00 PM
Girtablulu added a subscriber: Girtablulu.

Please remove the (issue #2243) stuff from the summary and the the changelog should be done with a list style as in D5946

This revision now requires changes to proceed.Apr 7 2019, 4:00 PM
Christoph3 updated this revision to Diff 14370.Apr 7 2019, 5:10 PM

Updated changelog

Christoph3 updated this revision to Diff 14371.Apr 7 2019, 5:14 PM
Christoph3 retitled this revision from Update version to 3.6.6 to Update Platformio to version 3.6.6.
Christoph3 edited the summary of this revision. (Show Details)

Updated changelog

Girtablulu added a comment.EditedApr 10 2019, 8:49 AM

I just saw you need to add a Resolves T7820 inside your summary, so the task will be automatically closed when accepted

https://getsol.us/articles/packaging/submitting-a-package/en/#commit

DataDrake accepted this revision.May 20 2019, 10:57 PM
DataDrake retitled this revision from Update Platformio to version 3.6.6 to Update Platformio to version 3.6.6, resolves T7820.
DataDrake edited the test plan for this revision. (Show Details)
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2019, 10:58 PM
This revision was automatically updated to reflect the committed changes.