Details
- Reviewers
JoshStrobl - Group Reviewers
Triage Team - Maniphest Tasks
- T3851: translate-shell
- Commits
- R3586:cb2172527c32: Initial version of translate-shell
$ trans -brief 'Solus est merveilleux!' Solus is wonderful!
Diff Detail
- Repository
- R3586 translate-shell
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Added a few comments to the package.yaml file regarding the build/install process as well as the rundeps and whether or not the espeak package should be added so that the Text-To-Speech functionality works.
| package.yml | ||
|---|---|---|
| 14 | Should we also add the espeak package as a rundep since we already have it in the repositories? Having espeak installed would mean being able to use the Text-to-Speech functionality. | |
| 17 | We should probably skip the build section since running make install calls the build macro in their Makefile meaning we are building the package twice. | |
| package.yml | ||
|---|---|---|
| 14 | I don't think it's a good idea to force it as a run dependency because most users won't use it. Those who want it can install it. Also, mpv can be used for t2s as well and is pre-installed on the Budgie and Gnome flavors. mpg123 can also be used for text-to-speech and many users might already have it as a dependency of another application. | |
| 17 | Right.. I'll add a workaround for this as well. | |
@kyrios123 I'm going to go ahead and upstream DESTDIR support for the Makefile so the PREFIX only needs to be /usr.
Submitted a PR. Let's go ahead and use ypkg's git support once the PR is merged so we don't need to have multiple git patches, assuming a new release isn't tagged.
Switch to git to get PR of @JoshStrobl and @kyrios123 without having to wait for next release