Page MenuHomeSolus

Initial version of translate-shell
ClosedPublic

Authored by kyrios123 on Jul 12 2017, 7:05 AM.

Details

Summary

Initial commit of translate-shell

Fixes T3851.

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan
$ trans -brief 'Solus est merveilleux!'
Solus is wonderful!

Diff Detail

Repository
R3586 translate-shell
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kyrios123 created this revision.Jul 12 2017, 7:05 AM

Added a few comments to the package.yaml file regarding the build/install process as well as the rundeps and whether or not the espeak package should be added so that the Text-To-Speech functionality works.

package.yml
14

Should we also add the espeak package as a rundep since we already have it in the repositories?

Having espeak installed would mean being able to use the Text-to-Speech functionality.

17

We should probably skip the build section since running make install calls the build macro in their Makefile meaning we are building the package twice.

kyrios123 updated this revision to Diff 1274.Jul 12 2017, 7:47 AM

install instead of cp man pages

kyrios123 added inline comments.Jul 12 2017, 8:02 AM
package.yml
14

I don't think it's a good idea to force it as a run dependency because most users won't use it. Those who want it can install it. Also, mpv can be used for t2s as well and is pre-installed on the Budgie and Gnome flavors. mpg123 can also be used for text-to-speech and many users might already have it as a dependency of another application.

17

Right.. I'll add a workaround for this as well.

kyrios123 updated this revision to Diff 1275.Jul 12 2017, 8:04 AM

Group workarounds to unfuck the Makefile in the setup section

@kyrios123 I'm going to go ahead and upstream DESTDIR support for the Makefile so the PREFIX only needs to be /usr.

Submitted a PR. Let's go ahead and use ypkg's git support once the PR is merged so we don't need to have multiple git patches, assuming a new release isn't tagged.

Submitted a PR. Let's go ahead and use ypkg's git support once the PR is merged so we don't need to have multiple git patches, assuming a new release isn't tagged.

Ok! :)

kyrios123 updated this revision to Diff 1361.Jul 16 2017, 3:04 PM

Switch to git to get PR of @JoshStrobl and @kyrios123 without having to wait for next release

JoshStrobl accepted this revision.Jul 16 2017, 3:13 PM
This revision is now accepted and ready to land.Jul 16 2017, 3:13 PM
This revision was automatically updated to reflect the committed changes.