Page MenuHomeSolus

update paramiko to 2.4.2
AbandonedPublic

Authored by hashhsah on Apr 1 2019, 6:44 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Summary

update paramiko to 2.4.2

Change log can be found at https://www.paramiko.org/changelog.html

Since we are jumping from 2.0.8 to 2.4.2, there are numerous changes that I'm not familiar with.
Personally, Ed25519 keys do not work under 2.0.8, and after the many Ed25519/ECDSA related fixes, 2.4.2 works for me fine.

Test Plan

start python3, and import paramiko

Diff Detail

Repository
R2637 python-paramiko
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
hashhsah created this revision.Apr 1 2019, 6:44 PM
hashhsah requested review of this revision.Apr 1 2019, 6:44 PM
JoshStrobl accepted this revision.Apr 1 2019, 7:05 PM
This revision is now accepted and ready to land.Apr 1 2019, 7:05 PM
JoshStrobl requested changes to this revision.Apr 1 2019, 7:06 PM

Actually needs a link to changelog or summarized changes.

This revision now requires changes to proceed.Apr 1 2019, 7:06 PM
hashhsah edited the summary of this revision. (Show Details)Apr 2 2019, 5:10 AM

@JoshStrobl a gentle reminder that requred change has been made, request another review

kyrios123 abandoned this revision.Apr 20 2019, 10:47 AM
kyrios123 added a subscriber: kyrios123.

@hashhsah your update was unseen because you did not change the status of the task back to Needs Review (it was still in Needs Revision and thus did not appear in the review queue)
Your patch was good, thanks a lot for it, but I submitted another one because I made quite many changes D6067

PS: For the next times, use this syntax for the links in the Summary: [text](url)