Page MenuHomeSolus

Initial commit of calc
ClosedPublic

Authored by pceiley on Mar 24 2019, 10:53 AM.

Details

Summary

Initial commit of calc. Resolves T6691.

Test Plan
  • Package installed successfully
  • calc executed successfully
  • Performed some basic calculations which worked as expected
  • Program exited cleanly
  • Man page works as expected using man calc

Diff Detail

Repository
R4689 calc
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
pceiley created this revision.Mar 24 2019, 10:53 AM
pceiley requested review of this revision.Mar 24 2019, 10:53 AM
JoshStrobl requested changes to this revision.Mar 24 2019, 11:19 AM
JoshStrobl added a subscriber: JoshStrobl.

Need a slightly more comprehensive test plan (how did you test it outside of installing it, which isn't a valid test), otherwise LGTM. Nice work 👍

This revision now requires changes to proceed.Mar 24 2019, 11:19 AM
pceiley edited the test plan for this revision. (Show Details)Mar 24 2019, 11:42 AM
pceiley requested review of this revision.Mar 24 2019, 7:13 PM

Thanks. I've updated the test plan.

The docs for building packages for Solus are top notch by the way.

JoshStrobl accepted this revision.Mar 27 2019, 12:02 PM
JoshStrobl retitled this revision from Initial commit for package request T6691 to Initial commit of calc.
JoshStrobl edited the summary of this revision. (Show Details)
JoshStrobl edited the test plan for this revision. (Show Details)

LGTM, thanks for the patch and congrats on the inclusion of your first package. Please remember that by taking on this package, you are becoming the package maintainer for it, and as such you will be responsible for ensuring it is updated.

This revision is now accepted and ready to land.Mar 27 2019, 12:03 PM
This revision was automatically updated to reflect the committed changes.

Discovered in a local rebuild that you did not include the ABI files. Please remember to follow our documentation and add the files specified / indicated there in the future. Thanks.

@JoshStrobl wrote:
LGTM, thanks for the patch and congrats on the inclusion of your first package. Please remember that by taking on this package, you are becoming the package maintainer for it, and as such you will be responsible for ensuring it is updated.

Thanks and appreciate the support. I was planning to keep it updated and am now 'watching' their github repo for new releases.

Discovered in a local rebuild that you did not include the ABI files. Please remember to follow our documentation and add the files specified / indicated there in the future. Thanks.

My bad, sorry. I didn't generate these at the time (didn't use make) but won't make that mistake again.