Bug fixes:
- Set a different default number (which is now 9) for SSH pools
- Adds a BaseHTTPAdapter with a close method to ensure that the pools is clean on close()
- Makes SSHHTTPAdapter reopen a closed connection when needed like the others
Differential D5809
Update python-docker-py to 3.7.1 Authored by der_eismann on Mar 22 2019, 10:19 AM. Tags None Referenced Files
Subscribers
Details
Bug fixes:
Installed and tested with Docker Compose 1.23.2
Diff Detail
Event TimelineComment Actions Because I am fed up with Solus and needing to beg for attention. Back when I joined I loved Solus for its ideas and spirit, but since then it became harder and harder to actually change something. Just to name a few points:
Solus is still an amazing project built by many volunteers, many of which aren't or weren't experts when they started. But damn, the communication is garbage. See my PXE enablement task because we were doing this stuff at work. I wanted to do it, contribute to the project. I didn't say "hey core team, do this for me!". Even the commits were already finished. Josh's response? "No because f you". No explanation, no reasons, we just don't have any plans right now. I talked about these problems before, but there seems to be no ambition to conquer these. TL;DR: Will start building packages for my own devices on my server or use another distro - maintainers for docker stack, php, dbeaver, Hashicorp stuff, kubectl, seafile and remmina wanted. Comment Actions I can answer some of the points.
You're not the only one who has patches waiting in the queue sometimes for a long time. I regularely go a IRC few days before a Sync to ask to review a submitted patch that is important to me or to ask a status of a patch that remains in the queue. Comment Actions I get your frustrations. We see them and aren't deaf to them. There are limits to what we are capable of doing right now, and unfortunately for you, most of that stuff has to wait for the Core Team to bring things up to speed. I'm not going to try to convince you to stay or of how best to spend your time. That's your decision and I will respect it. I'll quickly respond to your points and then I'd like to share my view of the situation so that you have a better idea of where I'm coming from:
Now that most of your concerns are at least partly addressed, I implore you to listen to why this is all taking so long. Personally: People forget sometimes that I'm not paid to do this. I'm still in school working hard towards earning a PhD. I get paid a stipend for living expenses. This takes an inordinate amount of time and has gotten steadily worse over the last two years. I typically work 60-80 hours a week on average. Couple that with Q1/Q2 being the busiest time of year for me and of course things are going to take longer. I also had an unfortunate accident in February that left we with a pretty badly sprained ankle which has made everything more difficult, adding an hour to my daily commute and making it extremely difficult to sit upright in a chair for long periods of time. Professionally: You say that our roadmap has nothing to do with community engagement and that couldn't be farther from the truth. Nearly everything we have on the docket for this year is a roadblock for contributing to Solus. We needed Weblate to even start handling translations properly and we are still learning the best ways to use it and integrate it into our projects. GNOME 3.32 is a huge blocker for updates and will take some time to build and test before it hits the repo. ypkg needs significant upgrades to help speed up patch reviews (linting especially) and deal with long-standing issues that lead to lots of time on workarounds for things that ypkg should already handle. Not to mention new versions of yauto and yupdate that don't mangle package.yml files. eopkg needs replacing because it's handing of things like file conflicts and circular dependencies have been a huge stumbling block for the last year. Just ask Girt how much time he's wasted fighting with file conflicts this year for Plasma. sold is necessary so that the Software Center can finally have proper integration with the package manager and so that we can get rid of our vulnerability to Python breakage. The new Software Center will fix way more of those open Phab tasks than you think. And then there's all of the problems we've had with ferryd in the past two months. You may not realize this, but I have been replacing large chunks of ferryd with every spare moment of coding time I have. It's become a huge bottleneck for weekly syncs and is at a point now that it is actually slowing down our ability to land patches quickly. And then there's the ongoing issues with the network for the package mirror that I've also been working to resolve. Every spare moment of mine is going towards keeping the critical items up to date and getting all of this behind the scenes stuff working so that you can get things done faster and so that the Core Team isn't your road block. We are in a period of tremendous renewal of core Solus codebases that are essential to smooth daily operation. This stuff takes time and can't be rushed. Patience is a virtue. Dictatorally: The Core Team is responsible for what gets added to Solus and deciding what we are willing to support. As a maintainer, you have some control over the things that you are responsible for, but ultimately we get the final say. You do not get to decide that you are going to add something completely new to Solus without us signing off on it. If we say "no", we expect you to respect our wishes and not pursue it further. If our explanation is lacking, ask for more information. We are generally very reasonable people and more often than not a "no" is more of a "not right now" than a "never". Comment Actions I was preparing for the release of Solus 4 as well as doing my own work outside of Solus, which will always take precedent. Solus 4 was originally slated for January of 2017, back when Ikey was part of the project, but was pushed back for a Software Center that was never completed. Then, we had to sort out infrastructure issues and get back on our feet after losing access to a significant portion of the infrastructure. The only reason Solus 3.9999 ISO Refresh went out was because of the repo URL change, having an ISO where people couldn't even upgrade (as would be the case for Solus 3) wasn't acceptable. So to say I was pre-occupied with the importance of ensuring a good Solus 4 release would be an understatement. I did not forget about including screenshots in translations, it was not a priority. Prioritization is something which occurs no matter the company, organization, or project. It can be a single-individual open source project and that individual would still prioritize items on importance. Screenshots in translations were not a blocker for the release of Solus 4 and I did not deem it a priority to resolve it while on vacation.
See above explanation. Surely you knew we released Solus 4, some understanding about prioritization would've been appreciated. Furthermore, you never asked me personally for a follow-up on it either.
If you have an issue with a specific translator, you should bring it up to them.
I indicated in the Improving Community Engagement blog post that there was multiple criteria which needed to be addressed. I then followed-up in Shiny Delights with a comprehensive list of messaging platforms and my evaluation of them. The reason we are still on IRC is because issues I highlighted have not been resolved yet. For Riot, it was laid out in:
This has not yet been resolved. The task is still in progress.
Neither of those two mentioned issues have been resolved either.
I have stated on multiple instances to you that such patches, such as to network-manager as well, are intentionally held off until the GNOME Stack upgrade. I'm not really sure why you expected a different response again, that wouldn't be consistent.
@kyrios123 already laid out why this would be an issue. So has @DataDrake in the past. You already know that.
We have stated on multiple occasions we have no desire for fwupd support until it is integrated into the Software Center and items around clr-boot-manager have been validated to be resolved. Any miniscule amount of research on our tracker into the matter would show our consistent answers on the matter. You can't really fault us for providing a patch for an item which wasn't going to be accepted in the first place. It'd be like providing a patch for a package request that was marked as WONTFIX, rejected for inclusion.
Your remarks in your task were:
As stated by @kyrios123 in his remarks to your task: "It is not really a problem to have to wait for a patch to be committed. I think IRC is a mandatory place for packagers." Reality is you rarely engage with us on IRC. You upload patches every Thursday or Friday (which I'm happy for, to be clear) but do not communicate with us any intentions around those. We can't engage with you if you don't engage with us. It's not a one-way street.
The community has gotten involved in the development of Budgie and helped reduce the amount of milestone issues that needed to be addressed for Budgie 10.5. Translations were done entirely by the community. Maintaining of packages reduces Core Team workload so we can focus on other items, or you know, take a vacation for once in two years.
And yet that number is 1/3 what it was less than a year ago. You'd see that by looking at our burnup rate. We went through and resolved a huge amount of issues, closed ones which had long been addressed by not triaged, etc. It's been holding steady around 400 for months now, because we've been mostly keeping up with tasks.
I have no issues taking over Docker. I was the original maintainer of it =) |