Page MenuHomeSolus

Initial commit of libthai
ClosedPublic

Authored by watpi on Mar 21 2019, 4:35 PM.

Details

Summary

Resolves T7721

Test Plan

Run Steam

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

watpi created this revision.Mar 21 2019, 4:35 PM
watpi requested review of this revision.Mar 21 2019, 4:35 PM
Girtablulu added inline comments.
package.yml
17

Configure marco does not work?

This comment was removed by watpi.
watpi updated this revision to Diff 13968.Mar 21 2019, 5:03 PM

Use %configure macro

aleksvor added inline comments.
package.yml
14–15

You don't need to explicitly list libdatrie here - it's listed in abi_used_libs, therefore it's automatically added as a rundep.

If you can use the macro, the prefix=/usr isnt needed anymore

watpi updated this revision to Diff 13973.Mar 21 2019, 7:18 PM

Remove prefix

watpi updated this revision to Diff 13975.EditedMar 21 2019, 7:24 PM

Remove rundep

JoshStrobl requested changes to this revision.Mar 22 2019, 11:33 AM
JoshStrobl added a subscriber: JoshStrobl.

You're missing a stack. Where is libdatrie?

This revision now requires changes to proceed.Mar 22 2019, 11:33 AM
watpi added a comment.EditedMar 22 2019, 11:42 AM

Add stack

DataDrake accepted this revision.Mar 22 2019, 10:50 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Revision.Mar 22 2019, 11:27 PM
Closed by commit R4686:902649d424d1: Initial commit of libthai (authored by watpi, committed by DataDrake). · Explain Why
This revision was automatically updated to reflect the committed changes.