Differential D5802

Initial commit of libthai
ClosedPublic
Actions

Authored by watpi on Mar 21 2019, 4:35 PM.

Tags

None

Subscribers

DataDrake, JoshStrobl, aleksvor, Girtablulu

Details

Reviewers

JoshStrobl
DataDrake

Group Reviewers

Maniphest Tasks

T7721: Steam requires libthai.so.0

Commits

R4686:902649d424d1: Initial commit of libthai

Summary

Resolves T7721

Test Plan

Run Steam

Diff Detail

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

watpi created this revision.Mar 21 2019, 4:35 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptMar 21 2019, 4:35 PM

watpi requested review of this revision.Mar 21 2019, 4:35 PM

Girtablulu added a subscriber: Girtablulu.Mar 21 2019, 4:49 PM

Girtablulu added inline comments.

package.yml
17	Configure marco does not work?

watpi added a comment.Mar 21 2019, 4:57 PM

This comment was removed by watpi.

Use %configure macro

aleksvor added a subscriber: aleksvor.Mar 21 2019, 5:38 PM

aleksvor added inline comments.

package.yml
14–15	You don't need to explicitly list libdatrie here - it's listed in `abi_used_libs`, therefore it's automatically added as a rundep.

If you can use the macro, the prefix=/usr isnt needed anymore

Remove prefix

Remove rundep

You're missing a stack. Where is libdatrie?

This revision now requires changes to proceed.Mar 22 2019, 11:33 AM

Add stack

watpi added a parent revision: D5801: Initial commit of libdatrie.Mar 22 2019, 11:50 AM

watpi removed a parent revision: D5801: Initial commit of libdatrie.

watpi added a parent revision: D5801: Initial commit of libdatrie.

watpi added a child revision: D5803: Add libdatrie, libthai and libselinux as rundeps to ensure web helper functionality.

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Revision.Mar 22 2019, 11:27 PM

Closed by commit R4686:902649d424d1: Initial commit of libthai (authored by watpi, committed by DataDrake). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
A	M		Makefile (1 line)
A	M		abi_symbols (78 lines)
A	M		abi_used_libs (2 lines)
A	M		package.yml (20 lines)
A	M		pspec_x86_64.xml (67 lines)

Diff 13973

Makefile

Loading...

abi_symbols

Loading...

abi_used_libs

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...