Page MenuHomeSolus

Update keepassx to 2.4.0
ClosedPublic

Authored by livingsilver94 on Mar 21 2019, 12:40 AM.

Details

Summary
  • New Database Wizard
  • Advanced Search
  • Automatic update checker
  • KeeShare database synchronization
  • Improve favicon fetching; transition to DuckDuckGo
  • Remove KeePassHttp support
  • CLI: output info to stderr for easier scripting
  • CLI: Add --quiet option
  • CLI: Add create command
  • CLI: Add recursive listing of entries
  • Prevent Klipper from storing secrets in clipboard
  • Use polling based file watching for NFS
  • Enable use of browser plugin in Snap build
  • TOTP QR Code Generator
  • High-DPI Scaling for 4k screens
  • Make keyboard shortcuts more consistent
  • Warn user if deleting referenced entries
  • Allow toolbar to be hidden and repositioned
  • Increase max allowed database timeout to 12 hours
  • Password generator uses existing password length by default
  • Improve alert message box button labels
  • Show message when a database merge makes no changes
  • Browser Integration Enhancements
  • Overall Code Improvements

Fixes T7717

Test Plan

Successfully opened my DB with password + key file. Created and deleted a test entry. Showed a TOTP QR code. Browser integration works.

Diff Detail

Repository
R1543 keepassx
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
livingsilver94 requested review of this revision.Mar 21 2019, 12:40 AM
livingsilver94 edited the summary of this revision. (Show Details)EditedMar 21 2019, 12:40 AM

I could also patch it to entirely disable update checking, but that would result in a fairly big patch to maintain.

Add missing patch file

livingsilver94 edited the summary of this revision. (Show Details)Mar 21 2019, 8:12 AM
livingsilver94 edited the test plan for this revision. (Show Details)Mar 21 2019, 1:55 PM

So is my patch no longer necessary? Are the yubikey tests still there?

So is my patch no longer necessary? Are the yubikey tests still there?

They added a flag for YubiKey tests: https://github.com/keepassxreboot/keepassxc/blob/develop/tests/CMakeLists.txt#L111

DataDrake accepted this revision.Mar 22 2019, 10:39 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Mar 22 2019, 10:39 PM
This revision was automatically updated to reflect the committed changes.