Details
Details
- Reviewers
JoshStrobl - Group Reviewers
Triage Team - Maniphest Tasks
- T4032: GPRename batch rename utility
- Commits
- R3602:041143228aa4: Initial version of gprename
- gprename appears in the menu -> ok
- run gprename -> ok
- rename a couple of test files and a couple of directories -> ok
Diff Detail
Diff Detail
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| files/gprename-build.patch | ||
|---|---|---|
| 16 ↗ | (On Diff #1250) | $(DESTDIR) should be changed to $(DESTDIR)$(PREFIX) |
| 19–23 ↗ | (On Diff #1250) | $(DESTDIR) should be changed to $(DESTDIR)$(PREFIX) |
| 29 ↗ | (On Diff #1250) | See my other comments. |
| 30–36 ↗ | (On Diff #1250) | See my other comments. |
| 39 ↗ | (On Diff #1250) | See my other comments. |
| package.yml | ||
| 21 | Wat. Our make_install macro already provided a correct DESTDIR, which is $installdir. This shouldn't be overwritten, gprename should be appropriately patched instead. | |
| files/0001-Fix-gprename-Makefile.patch | ||
|---|---|---|
| 100 | actually the path of the image files is set to /usr/share/icon everywhere except in 1 file, so if you agree I'd prefer keeping this path (I saw some other applications use this path as well). the icon appears in the menu, so the .desktop file can locate it there. I just have to update my sed command because the path for nautilus action icon is wrong. | |