Paths

Table of Contentst

Differential D5775

Update Riot to 1.0.4
ClosedPublic
Actions

Authored by alecbcs on Mar 18 2019, 3:45 PM.

Tags

None

Referenced Files

	F11069463: D5775.id13912.diff
	Fri, Aug 11, 11:04 PM

	F11069462: D5775.id13911.diff
	Fri, Aug 11, 11:04 PM

	F11069461: D5775.id13926.diff
	Fri, Aug 11, 11:04 PM

	F11069460: D5775.id.diff
	Fri, Aug 11, 11:04 PM

	F11051737: D5775.diff
	Thu, Aug 10, 8:16 PM

	F11032031: D5775.diff
	Wed, Aug 9, 1:48 PM

	F11020345: D5775.id13926.diff
	Mon, Aug 7, 3:56 AM

	F10997025: D5775.id13926.diff
	Thu, Jul 27, 1:33 AM

View All 17 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

R2816:2ae8aad0fe8a: Update Riot to 1.0.4

Summary

Updated Riot to 1.0.4 which includes updated dependencies and bug fixes.

Changelog:

Update from Weblate.
Switch to yarn for dependency management
Change olm dependency to normal dep
Add modular.im hosting link to electron app config
Nudge karma to 3.1.2
Add support for localConfig at $appData/config.json.

Test Plan

Tested 1.0.4 by sending and reciving multiple messages in group and personal chats. Everything functioned and looked as expected.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

alecbcs created this revision.Mar 18 2019, 3:45 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptMar 18 2019, 3:45 PM

alecbcs requested review of this revision.Mar 18 2019, 3:45 PM

JoshStrobl requested changes to this revision.Mar 18 2019, 3:47 PM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
25	yarn requires nodejs, so this isn't needed as a builddep.
29–31	You require yarn yet you're not using yarn to install deps or do the building?

This revision now requires changes to proceed.Mar 18 2019, 3:47 PM

Fix Yarn building

alecbcs marked 2 inline comments as done.Mar 18 2019, 4:08 PM

alecbcs added inline comments.

package.yml
29–31	Riot's build script automatically uses yarn when it's detected. This was a bit convoluted however, so I've updated it to use the yarn commands. Thanks for the catch!

JoshStrobl added inline comments.Mar 18 2019, 4:11 PM

package.yml
29	yarn will actually install deps if you pass just `yarn`

Changed yarn install to yarn

package.yml
29	Ahh okay, right! Thank you!

JoshStrobl accepted this revision.Mar 19 2019, 10:17 AM

This revision is now accepted and ready to land.Mar 19 2019, 10:17 AM

Closed by commit R2816:2ae8aad0fe8a: Update Riot to 1.0.4 (authored by alecbcs, committed by JoshStrobl). · Explain WhyMar 19 2019, 10:18 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

12 lines

pspec_x86_64.xml

116 lines

Diff 13926

package.yml

Loading...

pspec_x86_64.xml

Loading...