Page MenuHomeSolus

Update rustup to 1.18.1
ClosedPublic

Authored by josephscade on Mar 16 2019, 2:59 PM.

Details

Summary

New version released. See changelog here:
https://github.com/rust-lang/rustup.rs/blob/master/CHANGELOG.md

Test Plan

Install the stable toolchain as a regular user by running rustup install stable.

Diff Detail

Repository
R4626 rustup
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

josephscade created this revision.Mar 16 2019, 2:59 PM
josephscade requested review of this revision.Mar 16 2019, 2:59 PM

Remove an useless pipe.
This fixes pspec_x86_64.xml's License section.

Any thoughts about this diff?

The diff looks fine but I'd land it with the rust 1.33 which @livingsilver94 is working on, unless there is something urgent

Thank you for your answer.
As far as I know, it is not urgent to upgrade.
I just wanted some feedback because I was wandering why it wasn't accepted.

  • Bump to rustup 1.18.1
JoshStrobl requested changes to this revision.May 1 2019, 12:08 PM
JoshStrobl added a subscriber: JoshStrobl.

This should be release 3, not 4.

This revision now requires changes to proceed.May 1 2019, 12:08 PM

Fixes release number.

josephscade retitled this revision from Update rustup to 1.17.0 to Update rustup to 1.18.1.May 1 2019, 1:14 PM
JoshStrobl accepted this revision.May 1 2019, 1:17 PM

LGTM, thanks!

This revision is now accepted and ready to land.May 1 2019, 1:17 PM
This revision was automatically updated to reflect the committed changes.