Added new dependency
ClosedPublic
Actions

Authored by stigarn on Mar 16 2019, 8:53 AM.

Tags

None

Referenced Files

	F11019081: D5756.diff
	Sun, Aug 6, 5:18 PM

	F10849001: D5756.id13879.diff
	Jun 11 2023, 5:33 PM

	F10848859: D5756.id13880.diff
	Jun 11 2023, 4:57 PM

	F10848627: D5756.id14169.diff
	Jun 11 2023, 4:00 PM

	F10844644: D5756.id13878.diff
	Jun 10 2023, 9:34 PM

	F10826808: D5756.diff
	Jun 4 2023, 3:46 AM

	F10767097: D5756.id13878.diff
	May 19 2023, 10:05 PM

	F10763231: D5756.id.diff
	May 19 2023, 12:08 AM

View All 11 Files

Subscribers

DataDrake

JoshStrobl

Details

Reviewers

JoshStrobl
DataDrake

Group Reviewers

Triage Team

Commits

R4389:84d0d14af479: Added new dependency

Summary

Added new dependency missed in latest update.

Test Plan

Rebuilt with new dependency and tested that it worked to pipe text through.

Diff Detail

Repository

R4389 lolcat

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

stigarn created this revision.Mar 16 2019, 8:53 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptMar 16 2019, 8:53 AM

stigarn requested review of this revision.Mar 16 2019, 8:53 AM

Removed unneeded builddep

Fixed deps.

ruby-optimist isn't a thing. You missing a stack?

JoshStrobl requested changes to this revision.Mar 18 2019, 12:21 PM

This revision now requires changes to proceed.Mar 18 2019, 12:21 PM

Harvey mentioned this in T7779: lolcat ruby error (ruby-paint not found).Mar 29 2019, 12:17 PM

Girtablulu added a parent revision: D5875: Initial release of ruby-optimist.Mar 29 2019, 10:11 PM

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Revision.Mar 29 2019, 11:41 PM

Closed by commit R4389:84d0d14af479: Added new dependency (authored by stigarn, committed by DataDrake). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

package.yml

6 lines

Diff 14169

View Options

Added new dependencyClosedPublicActions