Page MenuHomeSolus

Initial commit of budgie-haste-applet
AbandonedPublic

Authored by mintspider on Mar 15 2019, 1:55 AM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Summary

Initial commit of budgie-haste-applet

Test Plan

Following Josh's instructions on his now old video at https://youtu.be/rlPnHjUBpJ8 - apart from this line!

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
mintspider created this revision.Mar 15 2019, 1:55 AM
mintspider requested review of this revision.Mar 15 2019, 1:55 AM
JoshStrobl requested changes to this revision.Mar 15 2019, 2:02 AM
JoshStrobl added a subscriber: JoshStrobl.

Feel free to test updating to correct the patch, then feel free to mark as abandoned 👍

package.yml
7

License should be SPDX-3.0 at this point. But given the videos are so old they predate that change, you're forgiven :P

This revision now requires changes to proceed.Mar 15 2019, 2:02 AM
mintspider updated this revision to Diff 13847.Mar 15 2019, 2:02 AM
mintspider edited the test plan for this revision. (Show Details)
mintspider removed a reviewer: JoshStrobl.

Initial commit of budgie-haste-applet

So when you update the diff, be sure that you're putting what you're changed, not "Initial commit of xyz" again :)

JoshStrobl requested changes to this revision.Mar 15 2019, 2:12 AM

Do not remove reviewers. Also still need to address the license not being SPDX-3.0. Check https://getsol.us/articles/packaging/packaging-practices/en/#licenses

This revision now requires changes to proceed.Mar 15 2019, 2:12 AM
mintspider abandoned this revision.Mar 15 2019, 2:13 AM

Still not bad for my *very first* package build on Solus.
As said in the YouTube comment, I shall need to do this again to fully grasp.
Class 101 felt like 111 to me!!!

mintspider added a comment.EditedMar 15 2019, 2:19 AM

The page does say: mintspider removed a reviewer: JoshStrobl.
However I have no idea how that happened as I intentionally did not do so.
Possibly when I re-submitted without a reviewer name and the timing of you adding yourself?

"So when you update the diff, be sure that you're putting what you're changed, not "Initial commit of xyz" again :)"

Followed your video! ;)

Certainly a good start. Welcome to the world of packaging!