Page MenuHomeSolus

Inclusion of libticables
ClosedPublic

Authored by flyingP0tat0 on Mar 13 2019, 7:43 PM.

Details

Summary

Part of T4770.

Test Plan

Indirectly through TiLP.

Diff Detail

Repository
R4709 libticables
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

flyingP0tat0 created this revision.Mar 13 2019, 7:43 PM
flyingP0tat0 requested review of this revision.Mar 13 2019, 7:43 PM
Girtablulu added inline comments.
package.yml
21

Should be 00644

Changed udev rule's file mode

flyingP0tat0 marked an inline comment as done.Mar 14 2019, 3:42 PM
JoshStrobl requested changes to this revision.Mar 29 2019, 1:10 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
15–16

Can just use %reconfigure instead of autoreconf then configure

This revision now requires changes to proceed.Mar 29 2019, 1:10 AM

Use of reconfigure macro

flyingP0tat0 marked an inline comment as done.Mar 29 2019, 10:36 AM
DataDrake accepted this revision.Mar 30 2019, 10:46 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Mar 30 2019, 10:48 PM
Closed by commit R4709:326e504a4063: Inclusion of libticables (authored by flyingP0tat0, committed by DataDrake). · Explain Why
This revision was automatically updated to reflect the committed changes.