Page MenuHomeSolus

Initial commit for maim
ClosedPublic

Authored by mbfraga on Jul 9 2017, 11:07 AM.
Tags
None
Referenced Files
F10999304: D571.id1388.diff
Fri, Jul 28, 12:06 PM
F10999303: D571.id1370.diff
Fri, Jul 28, 12:06 PM
F10998022: D571.id1238.diff
Thu, Jul 27, 4:30 PM
F10998020: D571.id.diff
Thu, Jul 27, 4:30 PM
F10995244: D571.diff
Wed, Jul 26, 3:38 AM
F10876118: D571.diff
Jun 20 2023, 9:11 AM
F10779485: D571.id.diff
May 24 2023, 5:48 PM
F10778575: D571.id1370.diff
May 24 2023, 9:14 AM
Subscribers

Details

Summary

Make initial maim package with solbuild for inclusion in the main repos
after revision. Addressing maim package request T3873

Test Plan

Build -> Ok

Installation -> Ok

Running -> Ok

Test all maim options -> Ok (used in production for two weeks)

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
8

Should be system.utils IMO, since it's a CLI utility.

This revision now requires changes to proceed.Jul 16 2017, 9:53 AM
mbfraga edited edge metadata.

I agree. That's what I had before, but for some reason I checked slop and decided to use the same.

Made the component system.utils

Did you do a second git commit then arc diff as opposed to amending your initial commit, as per our documentation? It only shows a diff between a now non-existent diff and the commit you pushed.

This revision now requires changes to proceed.Jul 17 2017, 12:29 PM
mbfraga edited edge metadata.
mbfraga marked an inline comment as done.

Rebased, fixed component, make (and checked results), commit --amend.

This revision is now accepted and ready to land.Jul 18 2017, 9:20 AM
This revision was automatically updated to reflect the committed changes.