Page MenuHomeSolus

Initial commit of ding
ClosedPublic

Authored by euoar on May 7 2017, 11:03 PM.
Tags
None
Referenced Files
F11066651: D56.id406.diff
Fri, Aug 11, 6:33 PM
F11066650: D56.id.diff
Fri, Aug 11, 6:33 PM
F11066649: D56.id108.diff
Fri, Aug 11, 6:32 PM
F11047507: D56.diff
Thu, Aug 10, 3:29 PM
F11038782: D56.id81.diff
Wed, Aug 9, 11:26 PM
F10998318: D56.id108.diff
Thu, Jul 27, 8:50 PM
F10998019: D56.diff
Thu, Jul 27, 4:29 PM
F10981551: D56.id108.diff
Sun, Jul 23, 6:56 AM
Subscribers
None

Details

Summary

Initial working patch for ding.
This closes T3526
The program works under Budgie and Gnome.
It won't under Mate until bug T3560 is resolved.
See the bug description for workarounds.

Diff Detail

Repository
R3474 ding
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Sorry for the mess with the binary file. I encountered this message using arc diff:
"Invalid Content Encoding (Non-UTF8)
This diff includes a file which is not valid UTF-8 (it has invalid byte
sequences). You can either stop this workflow and fix it, or continue. If you
continue, this file will be marked as binary.
You can learn more about how Phabricator handles character encodings (and how
to configure encoding settings and detect and correct encoding problems) by
reading 'User Guide: UTF-8 and Character Encoding' in the Phabricator
documentation.

AFFECTED FILE
files/0001-Patch-ding.patch

Invalid Content Encoding (Non-UTF8)
This diff includes a file which is not valid UTF-8 (it has invalid byte
sequences). You can either stop this workflow and fix it, or continue. If you
continue, this file will be marked as binary.

The file was uploaded as binary hence it can't be shown... :/
Any ideas of how to fix this issue so that the patch is uploaded as text?

Following the guide about UTF-8 I run /usr/bin/libphutil/scripts/utils/utf8.php files/0001-Patch-ding.patch, and it outputs some "offending lines in the patch":

30   # spell checker
31   set default_searchmeth(2,name) {Rechtschreibung}
32   set default_searchmeth(2,grepcmds) {hunspell ispell aspell}
33   set default_searchmeth(2,language1)  "Deutsche Rechtschreibpr<0xFC>fung"
34  -set default_searchmeth(2,grepopts)  "-B -d german -a"
35  +set default_searchmeth(2,grepopts)  "-B -d de_DE -a"

I managed to fix it and upload as text. Just in case someone else runs across the same issue, you can specify the encoding when running arc diff. In my case arc diff --encoding ISO-8859-1 made the trick.

This revision is now accepted and ready to land.May 26 2017, 1:48 PM
This revision was automatically updated to reflect the committed changes.