Page MenuHomeSolus

Update rust to 1.34.0 and extract cargo package
ClosedPublic

Authored by livingsilver94 on Mar 8 2019, 2:22 PM.

Details

Summary

You can find the release notes on the Rust blog:

Package changes

  • Enable i686 target

I also want to thank @Girtablulu for the initial assistance.

Test Plan

Successfully built bat and librsvg with local rust and cargo.

Diff Detail

Repository
R2839 rust
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

livingsilver94 created this revision.Mar 8 2019, 2:22 PM
livingsilver94 requested review of this revision.Mar 8 2019, 2:22 PM

Git rebase commits

livingsilver94 edited the summary of this revision. (Show Details)Mar 8 2019, 2:26 PM
livingsilver94 retitled this revision from Update rust to 1.33.0 to Update rust to 1.33.0 and extract cargo package.Mar 8 2019, 2:28 PM

Please run a testbuild against firefox and bat even test if possible rust code

files/config.toml.in
9–13

Why not using LIBDIR and sed it to %libdir% to make it flexible?

package.yml
26

remove whitespace

64

remove whitespace

68

remove whitespace

livingsilver94 added a comment.EditedMar 8 2019, 3:35 PM

Are you sure about the whitespaces? They're common. An example is https://dev.getsol.us/source/gpgme/browse/master/package.yml
About the rest, sure I will take care of it later!

livingsilver94 edited the summary of this revision. (Show Details)Mar 8 2019, 3:38 PM
livingsilver94 added a comment.EditedMar 8 2019, 6:13 PM

I have a problem here: in abi_used_libs there are the libraries needed by cargo, but these deps haven't been automatically specified as rundeps for the cargo package. In fact, when I execute it:

cargo: error while loading shared libraries: libgit2.so.26: cannot open shared object file: No such file or directory

Am I missing something? Of course I could specify them manually, but that's not how it usually works when the libs *are* in abi_used_libs.

Set specific CFLAGS for LLVM (I was told they are needed on the build server)

Remove another useless cat call

This comment was removed by livingsilver94.
livingsilver94 edited the test plan for this revision. (Show Details)Mar 11 2019, 12:15 PM

Use %libdir% macro

livingsilver94 marked an inline comment as done.Mar 11 2019, 12:20 PM

Have you done a test rebuild with firefox? This is our biggest package which needs cargo to build this has to be working

Not yet. There was a power outage in my area until a hour ago.

I can't test Firefox because of a known issue. I'm a noob at reading bug reports and patching, plus I'm currently ill. Any help is welcome, otherwise just be patient.

Firefox 68 got the fix, Firefox 67 patch is still pending.

So I manage to patch Firefox and it's building but it fails with thunderbird haven't figured out yet how to build it successfully :/

I can't test Firefox because of a known issue. I'm a noob at reading bug reports and patching, plus I'm currently ill. Any help is welcome, otherwise just be patient.

Firefox 66 got a "wontfix" label. Now we either patch Firefox ourselves or wait for the next release.
About Thunderbird, I really haven't had time to test it yet.

livingsilver94 retitled this revision from Update rust to 1.33.0 and extract cargo package to Update rust to 1.34.0 and extract cargo package.Apr 15 2019, 3:57 PM
livingsilver94 edited the summary of this revision. (Show Details)

Update to Rust 1.34

Enable 32-bit target & clean stuff

livingsilver94 edited the summary of this revision. (Show Details)Apr 19 2019, 3:50 PM
livingsilver94 edited the test plan for this revision. (Show Details)
JoshStrobl requested changes to this revision.Apr 24 2019, 7:29 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
pspec_x86_64.xml
21

Needs to be removed.

This revision now requires changes to proceed.Apr 24 2019, 7:29 AM
livingsilver94 added inline comments.Apr 24 2019, 2:10 PM
pspec_x86_64.xml
21

Even if it's empty?

Remove /etc directory

JoshStrobl accepted this revision.Apr 30 2019, 3:03 PM
This revision is now accepted and ready to land.Apr 30 2019, 3:03 PM
This revision was automatically updated to reflect the committed changes.