Page MenuHomeSolus
Differential D5624

Update python-qt5 to 5.12.1
ClosedPublic
Actions

Authored by BridouZ on Mar 7 2019, 7:44 AM.
Tags
None
Referenced Files
F11020954: D5624.id14831.diff
Mon, Aug 7, 10:20 AM
F11009938: D5624.diff
Wed, Aug 2, 9:30 PM
F10854914: D5624.id.diff
Jun 14 2023, 12:33 AM
F10846234: D5624.id14081.diff
Jun 11 2023, 4:04 AM
F10832306: D5624.id14831.diff
Jun 6 2023, 12:00 AM
F10829422: D5624.id14680.diff
Jun 4 2023, 12:06 PM
F10776443: D5624.id13970.diff
May 23 2023, 12:03 PM
F10766901: D5624.id.diff
May 19 2023, 9:04 PM
View All 14 Files
Subscribers
Girtablulu
JoshStrobl
kyrios123

Details

Reviewers
Girtablulu
JoshStrobl
Group Reviewers
Triage Team
Commits
R2679:2bbbe280cb66: Update python-qt5 to 5.12.1
Summary

Changelog:

  • Updated to 5.12.1
  • Removed pkgconfig(Qt5WebEngine) from builddeps
  • Changelog is here
Test Plan
  • Install OK
  • Build python3-qt5 against it OK
  • Tested against spyder and calibre, OK

Diff Detail

Repository
R2679 python-qt5
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

BridouZ created this revision.Mar 7 2019, 7:44 AM
Herald added a reviewer: Triage Team. · View Herald TranscriptMar 7 2019, 7:44 AM
BridouZ requested review of this revision.Mar 7 2019, 7:44 AM
BridouZ added a child revision: D5625: Update python3-qt5 to 5.12.1.
Girtablulu added a subscriber: Girtablulu.Mar 20 2019, 8:36 PM

There is now a version 5.12.1 and did you look into packaging the separation of PyQtWebEngine?

BridouZ updated this revision to Diff 13955.EditedMar 20 2019, 9:45 PM

Bump to 5.12.1, ping @Girtablulu ;)

BridouZ retitled this revision from Update python-qt5 to 5.12 to Update python-qt5 to 5.12.1.Mar 20 2019, 9:46 PM
BridouZ edited the summary of this revision. (Show Details)
Girtablulu added a comment.Mar 20 2019, 9:52 PM

cheers, trying to get this in ASAP is a little blocker for me for QT 5.12.2

Girtablulu added inline comments.Mar 20 2019, 9:56 PM
package.yml
20–21

Due the moved the webengine stuff into another package, this one is nor needed anymore

BridouZ added a comment.Mar 21 2019, 4:55 AM
In D5624#91456, @Girtablulu wrote:

cheers, trying to get this in ASAP is a little blocker for me for QT 5.12.2

Why is this a blocker for QT 5.12.2, it already fully supports this version

2019-03-17 Phil Thompson <phil@riverbankcomputing.com>

  • PyQt5.msp: Updated for Qt v5.12.2. [71df8ce4b154] <5.12-maint>
BridouZ updated this revision to Diff 13970.Mar 21 2019, 6:39 PM

Removed QTWebEngine as builddep

BridouZ edited the summary of this revision. (Show Details)Mar 21 2019, 6:40 PM
BridouZ edited the summary of this revision. (Show Details)
Girtablulu added a comment.Mar 25 2019, 2:17 PM

Sorry but you have to rebase it, I had to rebuild it for QT 5.12.2 stack update

BridouZ updated this revision to Diff 14081.Mar 25 2019, 5:46 PM

Rebase on QT5.12.2

Girtablulu added a comment.Mar 30 2019, 10:50 PM

Could you please test this against spyder and calibre to make sure other application are working as well besides qutebrowser

Girtablulu requested changes to this revision.Mar 30 2019, 10:52 PM
This revision now requires changes to proceed.Mar 30 2019, 10:52 PM
BridouZ edited the test plan for this revision. (Show Details)Apr 1 2019, 12:09 PM
kyrios123 added a subscriber: kyrios123.Apr 22 2019, 4:38 PM

This will have to be rebuild against D6092

BridouZ updated this revision to Diff 14680.Apr 23 2019, 10:54 AM

Rebuild against (local) D6092

JoshStrobl accepted this revision.Apr 29 2019, 7:06 PM
JoshStrobl added a subscriber: JoshStrobl.

@kyrios123 if you could land this when you land your python sip package, that'd be appreciated

JoshStrobl requested changes to this revision.Apr 29 2019, 7:07 PM

Correction, do not land this.

@BridouZ are you sure you know how to do rebases? Because this isn't rebased.

This revision now requires changes to proceed.Apr 29 2019, 7:07 PM
BridouZ updated this revision to Diff 14831.Apr 30 2019, 6:25 AM

Rebase on master

Sorry for missed attempts

JoshStrobl accepted this revision.May 7 2019, 2:39 PM
Girtablulu added a comment.May 7 2019, 2:42 PM

I'll land it when I push the QT Update

This revision was not accepted when it landed; it landed in state Needs Review.May 7 2019, 2:52 PM
Closed by commit R2679:2bbbe280cb66: Update python-qt5 to 5.12.1 (authored by BridouZ, committed by Girtablulu). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
6 lines
7 lines
64 lines

Diff 14958

View Options

abi_used_libs

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.