Page MenuHomeSolus

Update syncthing to 1.1.0
ClosedPublic

Authored by BridouZ on Mar 6 2019, 7:56 AM.

Details

Summary

Changelog:

  • Add networking access for the package to build
  • Add git as builddep
  • Syncthing changelog is available here
Test Plan
  • Install OK
  • Sync files OK

Diff Detail

Repository
R2989 syncthing
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
BridouZ created this revision.Mar 6 2019, 7:56 AM
BridouZ requested review of this revision.Mar 6 2019, 7:56 AM
JoshStrobl requested changes to this revision.Mar 6 2019, 8:27 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
6

You need to use the vendor source tarball.

This revision now requires changes to proceed.Mar 6 2019, 8:27 PM
BridouZ updated this revision to Diff 13620.Mar 7 2019, 7:24 AM

Switch to vendor source tarball

JoshStrobl requested changes to this revision.Mar 8 2019, 5:31 PM
JoshStrobl added inline comments.
package.yml
9

The whole point of the vendor source tarball is it ships vendored dependencies. Did you try removing networking and seeing if it still fetches go modules or even needs git? I doubt it needs either.

This revision now requires changes to proceed.Mar 8 2019, 5:31 PM
BridouZ marked an inline comment as done.Mar 8 2019, 6:16 PM

Build fails if not using network. It fetches some go modules for what I can see during the build process.

package.yml
9

Build fails if not using network. It fetches some go modules for what I can see during the build process.

BridouZ requested review of this revision.Mar 10 2019, 4:27 PM
JoshStrobl accepted this revision.Mar 15 2019, 10:31 AM
This revision is now accepted and ready to land.Mar 15 2019, 10:31 AM
This revision was automatically updated to reflect the committed changes.