Page MenuHomeSolus

Initial commit of kmahjongg
ClosedPublic

Authored by livingsilver94 on Mar 4 2019, 11:47 PM.

Details

Summary

Initial commit of kmahjongg.
Fixes T7590.

Test Plan

Successfully played a game and browsed into menus.

Diff Detail

Repository
R4678 kmahjongg
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
livingsilver94 created this revision.Mar 4 2019, 11:47 PM
livingsilver94 requested review of this revision.Mar 4 2019, 11:47 PM
livingsilver94 added inline comments.
package.yml
8

GNOME's mahjongg is games.cards. IMHO puzzle describes the game better.

livingsilver94 edited the summary of this revision. (Show Details)Mar 5 2019, 5:37 PM
JoshStrobl requested changes to this revision.Mar 6 2019, 8:38 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
8

games.puzzle likely didn't exist at the time. But yea, I agree.

24

Not needed. This is a dep of knewstuff-devel

This revision now requires changes to proceed.Mar 6 2019, 8:38 PM
livingsilver94 added inline comments.Mar 6 2019, 8:40 PM
package.yml
24

Oops, missed it during my check.

Remove unneeded package

livingsilver94 marked 2 inline comments as done.Mar 6 2019, 8:53 PM
JoshStrobl accepted this revision.Mar 6 2019, 9:29 PM
This revision is now accepted and ready to land.Mar 6 2019, 9:29 PM
This revision was automatically updated to reflect the committed changes.