Page MenuHomeSolus

Inclusion of radeon-profile resolves T7648
ClosedPublic

Authored by serebit on Mar 3 2019, 4:14 PM.

Details

Summary

Initial commit of radeon-profile

Test Plan

Viewed clocks and modified fan profile on an RX 480

Diff Detail

Repository
R4706 radeon-profile
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
serebit created this revision.Mar 3 2019, 4:14 PM
serebit requested review of this revision.Mar 3 2019, 4:14 PM
serebit retitled this revision from Initial commit of radeon-profile to Inclusion of radeon-profile resolves T7648.Mar 3 2019, 5:19 PM
serebit edited the summary of this revision. (Show Details)
livingsilver94 added inline comments.
package.yml
14

You can replace both lines 12 and 13 with - pkgconfig(Qt5Charts).

serebit updated this revision to Diff 13579.Mar 3 2019, 5:55 PM

Cleaned up script, merged some builddeps, rebuilt to include descriptions

serebit marked an inline comment as done.Mar 3 2019, 5:55 PM
aleksvor added inline comments.
package.yml
16–17

With C/C++ software you don't need to explicitly list rundeps in most cases - solbuild will scan the binaries and determine rundeps automatically. If libXrandr.so.2 is mentioned in abi_used_libs, then it means that solbuild already "knows" that xrandr is a dependency of radeon-profile.

serebit updated this revision to Diff 13580.Mar 3 2019, 6:27 PM

Removed explicit rundep on xrandr

serebit marked an inline comment as done.Mar 3 2019, 6:27 PM
serebit updated this revision to Diff 13582.Mar 3 2019, 6:47 PM

Added rundep on radeon-profile-daemon

This revision was not accepted when it landed; it landed in state Needs Review.Mar 30 2019, 10:25 PM
This revision was automatically updated to reflect the committed changes.