Page MenuHomeSolus

Update fish to 3.0.2
ClosedPublic

Authored by yursan9 on Mar 1 2019, 1:33 AM.

Details

Summary

Notable Improvment:

  • exec does not complain about running foreground job
  • read --silent no longer echoes the input to tty in interactive mode
  • Performance improvments to core shell functions and kill autocompletion
  • string prints help to stdout
Test Plan
  1. Open fish in terminal
  2. Run read --silent a, it shouldn't echo the input to terminal
  3. Run string --help > file to pipe help to stdout

Diff Detail

Repository
R759 fish
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
yursan9 created this revision.Mar 1 2019, 1:33 AM
yursan9 requested review of this revision.Mar 1 2019, 1:33 AM

From the release page:

Download links: To download the source code for fish, we suggest the file named "fish-3.0.2.tar.gz". The file downloaded from "Source code (tar.gz)" will not build correctly. The SHA-256 sum of this file is 14728ccc6b8e053d01526ebbd0822ca4eb0235e6487e832ec1d0d22f1395430e. A GPG signature from David Adam (0x7A67D962D88A709A) is available as "fish-3.0.2.tar.gz.asc".

That's the reason why I switched to the git tag in my previous version. Please consider using the other tarball or the git tag.

Well, IMHO, using git tags is the same as using Source code (tar.gz).

Nah. For example, fish --version returns unknown (or something like that) if built from the Github-generated tarball.

yursan9 added a comment.EditedMar 1 2019, 12:35 PM

Oh well, I guess I'll update the diff later. Still don't know why I can't use the signed tarball, but I guess I'll use git tag

yursan9 updated this revision to Diff 13551.Mar 2 2019, 3:25 AM

Use git tag as source

BridouZ added subscribers: kyrios123, BridouZ.EditedMar 7 2019, 11:48 AM

Sorry for the duplicate task.

Sorry for the duplicate task.

Is this the script you use?

@kyrios123 yes and I've just found why it was not working... Forgot to add my PhabToken :)

DataDrake accepted this revision.Mar 22 2019, 9:52 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Mar 22 2019, 9:52 PM
This revision was automatically updated to reflect the committed changes.