Page MenuHomeSolus

Update digikam to 6.0.0
AbandonedPublic

Authored by clivejo on Feb 25 2019, 9:44 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Summary

Update digikam to 6.0.0, changelog and release notes here

Test Plan

Use digikam to manage photo collection

Diff Detail

Repository
R625 digikam
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

clivejo created this revision.Feb 25 2019, 9:44 PM
clivejo requested review of this revision.Feb 25 2019, 9:44 PM
clivejo updated this revision to Diff 13463.Feb 25 2019, 9:47 PM

Remove runtime dep on kipi plugins

JoshStrobl requested changes to this revision.Mar 8 2019, 5:48 PM
JoshStrobl added a subscriber: JoshStrobl.

Why are we no longer building the plugins? Were they removed entirely? Is there another blocker for enabling them?

If they were deprecated entirely, you haven't sent a PR to getsolus/solus-sc to update the repo_data for the obsoleting.

This revision now requires changes to proceed.Mar 8 2019, 5:48 PM
clivejo added a comment.EditedMar 11 2019, 10:09 PM

Why are we no longer building the plugins? Were they removed entirely? Is there another blocker for enabling them?
If they were deprecated entirely, you haven't sent a PR to getsolus/solus-sc to update the repo_data for the obsoleting.

We are no longer building them because they don't exist. digiKam now uses a dedicated plugin interface instead, more powerful than KIPI stuff. More information will be published at next 6.1.0 release, but for now they are gone. I don't know how to send a PR to getsolus/solus-sc to update the repo_data for the obsoleting, have you some documentation on how to do this?

Regarding the missing docs this is a known issue (I believe it was forgotten about when the tarballs were created upstream), and is due to be fixed and reinstated in the next release 6.1.0. Can you suggest a method on how to deal with this?

Could I leave the pattern for the digikam-docs in place and ship an empty package, or maybe comment it out with an explanation as to why it is expected back in 6.1.0?

Why are we no longer building the plugins? Were they removed entirely? Is there another blocker for enabling them?
If they were deprecated entirely, you haven't sent a PR to getsolus/solus-sc to update the repo_data for the obsoleting.

We are no longer building them because they don't exist. digiKam now uses a dedicated plugin interface instead, more powerful than KIPI stuff. More information will be published at next 6.1.0 release, but for now they are gone. I don't know how to send a PR to getsolus/solus-sc to update the repo_data for the obsoleting, have you some documentation on how to do this?
Regarding the missing docs this is a known issues, and is due to be fixed and reinstated in the next release 6.1.0. Can you suggest a method on how to deal with this?
Could I leave the pattern for the digikam-docs in place and ship an empty package, or maybe comment it out with an explanation as to why it is expected back in 6.1.0?

Regarding the repo_data, the steps are:

  1. Fork https://github.com/getsolus/solus-sc
  2. Add an entry in repo_data/distribution.xml.in
  3. cd into repo_data and run the merged_repos.sh script. It'll generate the distribution.xml
  4. Do a PR.

If the docs are broken and the plugin bits are needing more details, I'd rather we wait until 6.1.0.

clivejo abandoned this revision.Mar 11 2019, 10:26 PM

Ok, fair enough, I'll abandon the patch