Page MenuHomeSolus

Update git to 2.21

Authored by livingsilver94 on Feb 24 2019, 7:57 PM.



You can find the lengthy release notes here.

Test Plan
  • Created a new repo
  • Added a file and committed it
  • Created a new branch
  • Repeated step 2 on the new branch
  • Merged master to the new branch

Also, unit tests passed.

Diff Detail

R909 git
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
livingsilver94 created this revision.Feb 24 2019, 7:57 PM
livingsilver94 requested review of this revision.Feb 24 2019, 7:57 PM
JoshStrobl requested changes to this revision.Feb 25 2019, 12:31 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.

Do these tests no longer exist? If now, why are they being removed?

This revision now requires changes to proceed.Feb 25 2019, 12:31 PM

Ah right, sorry if didn't write why I removed these lines. The tests are still here, I'd just like to give them a try another time. On my PC they're passing.

Right but the point is they fail on the build server. Your PC is not the build server :P

I know, Josh, but the line was lastly edited in September, many things could have changed since then. Can we try again with all tests enabled? If they fail, I'll just revert the lines.

No. They're just tests. I don't want to have to do a bump and re-add them. Add them back, thank you.

livingsilver94 updated this revision to Diff 13454.EditedFeb 25 2019, 7:45 PM

Re-disable some tests

livingsilver94 marked 2 inline comments as done.Feb 25 2019, 7:45 PM
JoshStrobl accepted this revision.Feb 27 2019, 3:17 PM
This revision is now accepted and ready to land.Feb 27 2019, 3:17 PM
This revision was automatically updated to reflect the committed changes.