Page MenuHomeSolus

Initial packaging of gnome-recipes
ClosedPublic

Authored by tristan957 on Jul 5 2017, 1:52 AM.
Tags
None
Referenced Files
F11066990: D551.diff
Fri, Aug 11, 7:11 PM
F11019184: D551.id1196.diff
Sun, Aug 6, 5:58 PM
F11005706: D551.diff
Tue, Aug 1, 9:27 AM
F10994749: D551.diff
Wed, Jul 26, 12:27 AM
F10944268: D551.id1195.diff
Fri, Jul 14, 10:43 PM
F10879278: D551.id.diff
Jun 21 2023, 10:46 PM
F10878430: D551.diff
Jun 21 2023, 9:05 AM
F10874559: D551.diff
Jun 20 2023, 12:57 AM
Subscribers

Details

Summary

Completes T2261, also applied dbus patch provided by Ikey

Test Plan

Install and browse around

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

@JoshStrobl I know you claimed this and it was in the Awaiting Package Upgrades column, but from what I can tell it finally had a release. The current version is 1.4.6 which I thought was odd, since its not 3.24 like other GNOME applications. Let me know if something should be changed.

Yea the reason I didn't add it was because I couldn't actually launch it from its desktop icon, only the terminal.

Oh that's what was going on. I'll do some more research into this

Yea I mean, if it launches from the desktop entry (I tested it under GNOME in its Applications overlay but Budgie should work just fine too) then fantastic, I'll get it merged.

The bug can be tracked here: https://bugzilla.gnome.org/show_bug.cgi?id=784535. Hopefully something will come of it. The Exec line in the .desktop is the exact same as the command line way to open it so I don't understand.

Made headway. Changing the value of DBusActivatable to false in the .desktop file allows the program to run. Since you know a little about dbus @ikey , what could this mean? It seems like this might be Budgie specific if I am understanding Josh right

Quite literally understood it as the opposite of what I said. It doesn't work via the desktop entry. I said *if it launches*, not *it launches*.

Quality english understanding from me

Made the comment on the wrong task because I am a dumb dumb. "Seems that the issue got fixed. I'll wait for a new source tarball and then I can repackage this unless you still want it @JoshStrobl . Also shout out to @ikey for stepping in on the GNOME bug tracker."

JoshStrobl requested changes to this revision.EditedJul 6 2017, 12:28 AM

Ya feel free to land the patch Ikey provided in the GNOME Bugzilla task :) and remove the prefix bit from meson_configure, since it is part of our macro. The rest of the package you provided looked good to me.

This revision now requires changes to proceed.Jul 6 2017, 12:28 AM

Alright will get the changes in. Just gotta remember how to apply a patch in my package.yml

tristan957 edited edge metadata.
tristan957 edited the summary of this revision. (Show Details)

Applied the new patch provided by Ikey

This revision is now accepted and ready to land.Jul 6 2017, 2:49 AM
This revision was automatically updated to reflect the committed changes.