Page MenuHomeSolus

Initial commit of lollypop-portal
ClosedPublic

Authored by FriesischScott on May 7 2017, 9:38 PM.

Details

Summary

Initial commit of lollypop-portal. Closes T3628. This enables Lollypop
to call kid3-cli. See T3203.

Diff Detail

Repository
R3397 lollypop-portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

FriesischScott created this revision.May 7 2017, 9:38 PM
FriesischScott retitled this revision from Initial commit to Initial commit of lollypop-portal.
JoshStrobl added a subscriber: JoshStrobl.

Depends on D54.

Also is this something that's been tested without flatpak or is it something that should be added as a rundep?

FriesischScott added a comment.EditedMay 8 2017, 10:08 AM

Adding this as a rundep makes sense. Without this Lollypop can neither make changes to the files on in its own using kid3-cli nor provide a context menu to open the file in any audio tagger for editing, but Lollypop never tells the user that you need this.

It even says on the Lollypop github:
*For packagers: You need to provide https://github.com/gnumdk/lollypop-portal

I have tested it without flatpak and it works.

JoshStrobl accepted this revision.May 10 2017, 1:47 PM

Adding this as a rundep makes sense.

Wasn't talking about adding lollypop-portal to lollypop as a rundep, was talking about Flatpak, but you answered that question nonetheless :D

This revision is now accepted and ready to land.May 10 2017, 1:47 PM
This revision was automatically updated to reflect the committed changes.