Differential D540

update nodejs to 8.1.3
AbandonedPublic
Actions

Authored by mcritchlow on Jul 2 2017, 4:19 AM.

Details

Reviewers

None

Group Reviewers

Triage Team

Summary

Brings nodejs to version 8.

Several significant changes were introduced. Full Changelog: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V8.md

Test Plan

Installed locally. Version reported successfully. Ran using an existing Ruby/Rails app that depends on nodejs
as the JS runtime. Everything appears to work as expected. That said, I realize this is a significant upgrade so if
others can test that would be ideal.

Diff Detail

Repository

R2177 nodejs

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

mcritchlow created this revision.Jul 2 2017, 4:19 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptJul 2 2017, 4:19 AM

I won't be upgrading nodejs until I'm able to personally build, validate, as well as build our existing nodejs applications, with numerous having spotty support for nodejs 7, let alone nodejs 8.

In D540#7751, @JoshStrobl wrote:

I won't be upgrading nodejs until I'm able to personally build, validate, as well as build our existing nodejs applications, with numerous having spotty support for nodejs 7, let alone nodejs 8.

Node.js 7.x will leave maintenance mode very soon (LTS schedule). Could you not have something like nodejs-lts (6.x) and nodejs-current (8.x), or does that complicate things too much?