Page MenuHomeSolus

Initial commit of Kid3
ClosedPublic

Authored by FriesischScott on May 7 2017, 9:34 PM.

Details

Summary

Initial commit of Kid3. Closes T3203. Depends on T3628 for Lollypop to be
able to actually call ki3d-cli.

See D55.

Diff Detail

Repository
R3400 kid3
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

FriesischScott created this revision.May 7 2017, 9:34 PM
FriesischScott edited the summary of this revision. (Show Details)May 7 2017, 9:39 PM
FriesischScott retitled this revision from Initial commit to Initial commit of Kid3.
JoshStrobl requested changes to this revision.May 8 2017, 7:11 AM
JoshStrobl added a subscriber: JoshStrobl.

Since lollypop needs the CLI and not GUI, I would recommend using a patterns and rundeps to split kid3 up into:

  • lib: with the appropriate shared object files, shared files
  • cli: CLI bits, associated man files
  • gui: Qt gui binary, desktop file, icons, etc.
package.yml
17

Unnecessary. ogg is a dependency of flac and vorbis.

This revision now requires changes to proceed.May 8 2017, 7:11 AM

I like the idea of splitting this up. Having the GUI and CLI in separate packages allows Lollypop to save changes to the files while still allowing the user to choose an alternative audio tagger for the context menu. When the kid3 GUI is installed it is always favored over alternative taggers. I'll have a look at this later.

FriesischScott updated this revision to Diff 107.EditedMay 8 2017, 9:31 PM
FriesischScott edited edge metadata.

Split into kid3, kid3-cli and kid3-qt

This is my first attempt at splitting the package. I was not exactly sure how to do this.
My intend was to have the cli and gui independent of each other depending on kid3.

Is it possible to have different summaries/descriptions for the subpackages?

JoshStrobl added a comment.EditedMay 10 2017, 1:18 PM

Is it possible to have different summaries/descriptions for the subpackages?

Yes. Example at https://dev.solus-project.com/source/libreoffice/browse/master/package.yml;9e1a6818dac4037617b317cdea534153db04b5d6$62

Edit: Going to mark as "needs fixes" pending the description stuff. It isn't a requirement, the patch itself looks good, but separate descriptions couldn't hurt.

JoshStrobl requested changes to this revision.May 10 2017, 2:13 PM
This revision now requires changes to proceed.May 10 2017, 2:13 PM
FriesischScott edited edge metadata.
FriesischScott marked an inline comment as done.

I renamed kid3 to kid3-core which better explains its purpose. Additionally kid3-core,
kid3-cli and kid3-qt now each have their own summary and description.

JoshStrobl accepted this revision.May 11 2017, 8:42 AM

LGTM, good work.

This revision is now accepted and ready to land.May 11 2017, 8:42 AM
This revision was automatically updated to reflect the committed changes.