Page MenuHomeSolus

Update Wire to 3.6.2885
ClosedPublic

Authored by aleksvor on Feb 18 2019, 6:24 PM.

Details

Summary

Upstream changelog:

  • SSO links. Company login users can now log in using their identity provider faster, by tapping on a custom link.
  • Cross-domain Identity Management (SCIM) integration for the automation of user provisioning.

Packaging changes:

  • Removed bundled libffmpeg.so so Wire links against our ffmpeg-chromium.
  • Removed libEGL.so and libGLESv2.so and symlinked them to system versions.
Test Plan

Established audio conversation.

Diff Detail

Repository
R3172 wire
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

aleksvor created this revision.Feb 18 2019, 6:24 PM
aleksvor requested review of this revision.Feb 18 2019, 6:24 PM
JoshStrobl requested changes to this revision.Feb 21 2019, 1:38 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
36–41

Most of this can be simplified:

  1. rm $installdir/usr/share/wire/libffmpeg.so could be changed to rm $installdir/usr/share/wire/lib{ffmpeg,EGL,GLESv2}.so
  2. rm $installdir/usr/share/wire/swiftshader/libEGL.so could be changed to rm $installdir/usr/share/wire/swiftshader/lib{EGL,GLESv2}.so
This revision now requires changes to proceed.Feb 21 2019, 1:38 PM
aleksvor updated this revision to Diff 13367.Feb 21 2019, 3:35 PM

Simplified deletion of unwanted libraries.

Also shouldn't you be symlinking the libffmpeg from ffmpeg-chromium to /usr/share/wire/libffmpeg.so?

Also shouldn't you be symlinking the libffmpeg from ffmpeg-chromium to /usr/share/wire/libffmpeg.so?

I think it's not necessary:

  1. When seeking for runtime dependencies, ypkg determines libffmpeg.so from ffmpeg-chromium as a rundep (and adds it in abi_used_libs)
  2. When I run Wire, I can see that /usr/lib64/libffmpeg.so is linked in process memory map.

I used our packages for Vivaldi and Opera as a reference when I made these changes, but only now I notice that we symlink libffmpeg.so in Vivaldi packages. However, we don't do it in Opera package.

Of course I can add symlink if it's needed, but I don't think it's necessary.

I originally symlinked libffmpeg.so in vivaldi-snapshot to remove a confusing console warning that stated H264 support was not enabled when in fact, it was working. Generally it is not necessary to symlink. Abi report to smart enough to add it as a dependency if ffmpeg-chromium is added to builddeps.

JoshStrobl accepted this revision.Feb 25 2019, 12:26 PM
This revision is now accepted and ready to land.Feb 25 2019, 12:26 PM
This revision was automatically updated to reflect the committed changes.