Page MenuHomeSolus

Update retroarch to 1.7.6 and integrate various other improvements
ClosedPublic

Authored by Jacalz on Mon, Feb 4, 5:14 PM.

Details

Summary

Full changelog can be found here.

Packaging Changes:

  • Enabled support for QT5 based desktop UI
  • Enabled support for jack-audio-connection-kit
Test Plan
  • Installed, downloaded assets, installed a couple cores and played some SNES-games from the Material UI.
  • Pressed F5 to go in to Desktop UI.
  • Started Dolphin-emu Wii games from both desktop UI and material UI.
  • Played SNED games from Desktop UI.

Diff Detail

Repository
R2809 retroarch
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Jacalz created this revision.Mon, Feb 4, 5:14 PM
Jacalz requested review of this revision.Mon, Feb 4, 5:14 PM

Could you enable Desktop UI?

I think you accidentally pushed that tarball. Please remove it ;)

kyrios123 added inline comments.
package.yml
47

Why are the libwayland gone while the enable option is set and pkgconfig(wayland-egl) is in the builddeps ?

libwayland-client.so.0
libwayland-cursor.so.0
libwayland-egl.so.1
Jacalz updated this revision to Diff 12840.Tue, Feb 5, 5:06 PM
  • Remove tarball that I accidentally pushed
package.yml
47

I honestly have no idea :I

livingsilver94 added a comment.EditedTue, Feb 5, 5:07 PM

Also, you should be able to replace ./configure with our %configure macro and to remove --prefix=/usr since it's already included in the macro

Jacalz added a comment.Tue, Feb 5, 5:07 PM

Good catch @livingsilver94! Will see if I can get the desktop UI to work ๐Ÿ™‚

Jacalz added a comment.Tue, Feb 5, 5:10 PM

I already tested that @livingsilver94 and it runs in to the same issue as with D4882 where the script fails due to unknown options passed. It won't cut it, I'm sorry...

You're right. From here:

An unknown option ordinarily indicates a mistake by the user and configure halts with an error.

Meh :-/

Jacalz added a comment.Tue, Feb 5, 5:18 PM

I also honestly have no idea how to build the desktop UI and I can't find any good information on the matter :/

Try to pass --enable-qt. At least that's what I understood from the source code...

Jacalz added inline comments.Tue, Feb 5, 5:39 PM
package.yml
47

I checked in the information tab and it reports Wayland as disabled but EGL as enabled ๐Ÿ™

Jacalz added a comment.Tue, Feb 5, 6:10 PM

I can't get the UI to work even when passing --enable-qt, will hand that to someone else after this commit.

Jacalz updated this revision to Diff 12843.Tue, Feb 5, 6:15 PM
  • Add support for JACK now that we can actually use it reliably
Jacalz retitled this revision from Update retroarch to 1.7.6 to Update retroarch to 1.7.6 and add JACK support.Tue, Feb 5, 6:16 PM
Jacalz edited the summary of this revision. (Show Details)
Jacalz updated this revision to Diff 12845.Tue, Feb 5, 6:18 PM
  • Remove --enable-qt because I can't seem to get desktop UI working

For Qt companion GUI: - pkgconfig(Qt5Gui) and --enable-qt \.

It would also be cool to remove builtin 3d-party libraries like flac and mbedtls. Take a look here https://github.com/libretro/RetroArch/blob/v1.7.6/qb/config.params.sh and pass --disable-builtin[X] to nuke it. If it complains about a missing dep, that is it's mandatory, make sure to add it as as builddep so that we use our version.

Jacalz updated this revision to Diff 12847.Tue, Feb 5, 7:02 PM
Jacalz retitled this revision from Update retroarch to 1.7.6 and add JACK support to Update retroarch to 1.7.6 and integrate various other improvements.Tue, Feb 5, 7:03 PM
Jacalz edited the summary of this revision. (Show Details)
Jacalz edited the test plan for this revision. (Show Details)
Jacalz updated this revision to Diff 12850.Tue, Feb 5, 7:20 PM
  • Fix wayland support
Jacalz marked 3 inline comments as done.Tue, Feb 5, 7:22 PM
Jacalz added inline comments.
package.yml
47

I fixed it by adding wayland-protocols to the builddeps ๐Ÿ‘

Jacalz marked an inline comment as done.Tue, Feb 5, 7:22 PM

Unfortunately couldn't get that to work @livingsilver94 but I did manage to fix Wayland support ๐Ÿ‘

kyrios123 added inline comments.Tue, Feb 5, 7:25 PM
package.yml
47

good job! ๐Ÿ˜„

livingsilver94 added inline comments.Tue, Feb 5, 7:53 PM
package.yml
13โ€“14

Not needed anymore. There's already a higher-level dependency listed.

14

Not needed anymore. There's already a higher-level dependency listed.

15โ€“16

Not needed anymore. There's already a higher-level dependency listed.

23โ€“24

Not needed anymore. There's already a higher-level dependency listed.

24

Not needed anymore. There's already a higher-level dependency listed.

Jacalz edited the test plan for this revision. (Show Details)Wed, Feb 6, 6:11 AM
Jacalz updated this revision to Diff 12881.Wed, Feb 6, 5:41 PM
Jacalz marked 5 inline comments as done.
  • Remove unneeded dependencies to speed up build
Jacalz added a comment.Wed, Feb 6, 5:42 PM

Fixed with the new push

Great job! Sorry for having been pedantic but this package really needed some fixes.
Now, what's left is to just remove bundled libs, but I guess we can ignore this for now :)

Jacalz added a comment.Thu, Feb 7, 5:57 AM

Thanks @livingsilver94, but there is no need to apologize. I have learned a ton in the process and RetroArch users like me and many others will benefit a lot from the changes ๐Ÿ™‚

DataDrake accepted this revision.Sat, Feb 9, 3:23 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Sat, Feb 9, 3:23 PM
This revision was automatically updated to reflect the committed changes.