Page MenuHomeSolus

Rebuild against QT 5.12.1 and updated to 5.11.3
ClosedPublic

Authored by Girtablulu on Feb 4 2019, 1:00 AM.

Details

Summary

Rebuild against QT 5.12.1 and updated to 5.11.3

Depends on D5284

Changelog:

  • Fixed QByteArrat.at() and getitem() to return a byte with Python
  • Updated the OpenGL examples to explicitly set a supported OpenGL
  • Fixed a regression in the handling of signals with 'const char *'
  • Renamed QRandomGenerator.global() to global_().
  • Fixed the qmlscene and designer plugins to use the private copy of the sip module.
Test Plan

Rebuild calibre/spyder against it

Diff Detail

Repository
R2679 python-qt5
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Girtablulu created this revision.Feb 4 2019, 1:00 AM
Girtablulu requested review of this revision.Feb 4 2019, 1:00 AM
JoshStrobl retitled this revision from Rebuild against QT5.12.1 and Updateed to 5.11.3 to Rebuild against QT 5.12.1 and updated to 5.11.3.Feb 5 2019, 1:24 PM
JoshStrobl edited the summary of this revision. (Show Details)
JoshStrobl added inline comments.
package.yml
41

Is there a specific reason -j1 is being passed?

JoshStrobl requested changes to this revision.Feb 5 2019, 1:28 PM
This revision now requires changes to proceed.Feb 5 2019, 1:28 PM

yes build always fails if I do not set -j1

Girtablulu requested review of this revision.Feb 6 2019, 1:06 AM
JoshStrobl requested changes to this revision.Feb 6 2019, 5:12 PM
JoshStrobl added inline comments.
package.yml
29

Trailing whitespace here.

This revision now requires changes to proceed.Feb 6 2019, 5:12 PM
Girtablulu updated this revision to Diff 12886.Feb 6 2019, 6:00 PM

Remove white space

JoshStrobl accepted this revision.Feb 7 2019, 3:54 PM
This revision is now accepted and ready to land.Feb 7 2019, 3:54 PM
This revision was automatically updated to reflect the committed changes.