Page MenuHomeSolus

Rebuild for QT 5.12.1 and updated to 5.19.13
ClosedPublic

Authored by Girtablulu on Feb 4 2019, 12:53 AM.

Details

Summary

Rebuild for QT 5.12.1 and updated to 5.19.13

Changelog:

  • The sphinx extension now uses a single ref role.
  • The default values arguments have reST references added if possible in the XML export.
  • Added argument names and default values to the XML export.
  • Restored the inclusion of reST references in the XML export.
Test Plan

Build python-qt5 against it which is a dep of calibre, which rebuilt fine and was working by installing

Diff Detail

Repository
R2693 python-sip
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Girtablulu created this revision.Feb 4 2019, 12:53 AM
Girtablulu requested review of this revision.Feb 4 2019, 12:53 AM
JoshStrobl requested changes to this revision.Feb 5 2019, 1:22 PM
JoshStrobl retitled this revision from Rebuild fot QT 5.12.1 and updated to 5.19.13 to Rebuild for QT 5.12.1 and updated to 5.19.13.
JoshStrobl edited the summary of this revision. (Show Details)
JoshStrobl edited the summary of this revision. (Show Details)
JoshStrobl added a subscriber: JoshStrobl.

Rebuild calibre with it

Calibre doesn't use this, python-qt4 and python-qt5 do. Test plan should be accurate.

This revision now requires changes to proceed.Feb 5 2019, 1:24 PM
Girtablulu updated this revision to Diff 12833.Feb 5 2019, 3:23 PM
Girtablulu edited the test plan for this revision. (Show Details)

Updated the testplan how I actually tested it

JoshStrobl accepted this revision.Feb 6 2019, 5:11 PM
JoshStrobl edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Feb 6 2019, 5:12 PM
This revision was automatically updated to reflect the committed changes.