Page MenuHomeSolus

Update to QT 5.12.1
ClosedPublic

Authored by Girtablulu on Feb 4 2019, 12:32 AM.

Details

Summary

Update to QT 5.12.1
Changelog available here

Test Plan

Installed and rebooted no issues with the plasma desktop used falkon,qownnotes,musescore and lattedock

Diff Detail

Repository
R2738 qt5-declarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Girtablulu created this revision.Feb 4 2019, 12:32 AM
Girtablulu requested review of this revision.Feb 4 2019, 12:32 AM
JoshStrobl requested changes to this revision.Feb 5 2019, 2:04 PM
JoshStrobl added a subscriber: JoshStrobl.

Installed and rebooted

What about qownnotes? musescore? etc.

abi_used_libs
8

What happened here? Are they not using qt5-xmlpatterns anymore? If not, builddep sohuld be removed. But seeing as the purpose of this library is to handle "string, xml, and network handling" - the lack of XML bit is concerning.

This revision now requires changes to proceed.Feb 5 2019, 2:04 PM
Girtablulu updated this revision to Diff 12854.Feb 5 2019, 11:56 PM
Girtablulu edited the test plan for this revision. (Show Details)

Update testplan

abi_used_libs
8

I removed it and builds without issue and tested with several softwares and no issues there as well

JoshStrobl accepted this revision.Feb 6 2019, 5:10 PM

Looks like the XMLListModel was moved to xmlpatterns in 5.12.0 per http://code.qt.io/cgit/qt/qtdeclarative.git/commit/?h=v5.12.1&id=0477a057fd02050fd330760bf046f5e0e91a9331 so going to accept this.

This revision is now accepted and ready to land.Feb 6 2019, 5:10 PM
This revision was automatically updated to reflect the committed changes.