Page MenuHomeSolus

Update to 0.5.0.1 and fix dependencies
ClosedPublic

Authored by Jacalz on Feb 3 2019, 8:20 PM.

Details

Summary

Summarized Changelog:

  • Initialize playtime attribute when invalid playtime found
  • Add application attribute on GenericPanel
  • Avoid crashing on weird GPU config
  • Remove get_config_id

Packaging:

  • Fix dependencies to make the program actually starts on Plasma and fix notifications

Fixes T7564

Test Plan

Diff Detail

Repository
R1992 lutris
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Jacalz created this revision.Feb 3 2019, 8:20 PM
Jacalz requested review of this revision.Feb 3 2019, 8:20 PM
Jacalz updated this revision to Diff 12787.
  • Fix more strange shit produced by the build

The "weird shit" in pspec is due to the fact you didn't do +1 on the release number ๐Ÿ˜›

livingsilver94 added inline comments.Feb 3 2019, 8:28 PM
package.yml
18โ€“19

Since you're here, please also fix the order of the rundeps.

Jacalz added a comment.Feb 3 2019, 8:29 PM

I will fix that ASAP ๐Ÿ‘

Jacalz updated this revision to Diff 12789.Feb 3 2019, 8:35 PM
  • Fix some stuff because I need sleep
Jacalz marked an inline comment as done.Feb 3 2019, 8:35 PM
Jacalz edited the summary of this revision. (Show Details)
livingsilver94 added a comment.EditedFeb 3 2019, 9:47 PM

Ok, I managed to run tests. Well, I technically didn't as tests for lutris are supposed to be manual, nevertheless python3 setup.py test imported all the Python code and that helped me to figure out what lutris needs to work properly. Here are the rundeps:

- libgnome-desktop
- libgnome-keyring
- libwebkit-gtk
- notify-python
- python-evdev
- python-pillow
- python-requests
- python3-gobject

None of them is needed to build lutris, so the builddeps block can be removed.

Reordered runtime dependencies in alphabetical order

This should not be in the summary because the summary is meant for the end user, they don't care about packaging details.

Ah right, my test plan on Plasma:

  • lutris started successfully
  • Browsed in lutris windows, like preferences and advanced Steam settings
  • Launched the Steam client

You can look in the setup.py and eventually in requirements.txt (if it exists) to find out about dependecies

Jacalz edited the summary of this revision. (Show Details)Feb 4 2019, 7:58 AM
livingsilver94 added a comment.EditedFeb 4 2019, 9:49 AM

I know that @kyrios123, but they're not entirely listed. For example, libwebkit-gtk is completely missing and, oddly, pyyaml is not used, at least in tests.
We should probably take the time to manually run those tests as lutris devs intended.

JoshStrobl requested changes to this revision.Feb 4 2019, 11:58 AM
JoshStrobl added a subscriber: JoshStrobl.

Let's get this updated to 0.5.0.1 while we're at it.

This revision now requires changes to proceed.Feb 4 2019, 11:58 AM
Jacalz updated this revision to Diff 12822.Feb 4 2019, 4:36 PM
  • Add change rundeps, remove all builddeps and update 0.5.0.1
Jacalz retitled this revision from Add libwebkit-gtk as dependency to Update to 0.5.0.1 and fix dependencies.Feb 4 2019, 4:40 PM
Jacalz edited the summary of this revision. (Show Details)
Jacalz edited the test plan for this revision. (Show Details)
JoshStrobl edited the summary of this revision. (Show Details)Feb 4 2019, 5:06 PM
JoshStrobl requested changes to this revision.Feb 4 2019, 5:13 PM
JoshStrobl added inline comments.
package.yml
30

Why was this removed? They have YAML functionality for configuration and their installer bits. You can easily see it in lutris/util/yaml.py, lutris/config.py, lutris/installer/interpreter.py, etc.

This revision now requires changes to proceed.Feb 4 2019, 5:13 PM
Jacalz added inline comments.Feb 4 2019, 5:16 PM
package.yml
30

It was removed by mistake because it wasn't on the test list from @livingsilver94, I see that it is needed and I will add it back ๐Ÿ‘

Jacalz updated this revision to Diff 12824.EditedFeb 4 2019, 5:18 PM
  • Add back pyyaml that I accidentally removed
Jacalz marked 2 inline comments as done.Feb 4 2019, 5:18 PM
JoshStrobl accepted this revision.Feb 4 2019, 5:19 PM
This revision is now accepted and ready to land.Feb 4 2019, 5:19 PM

LGTM now. Thanks for the patch ๐Ÿ‘

Jacalz added a comment.Feb 4 2019, 5:20 PM

You are welcome ๐Ÿ™‚ Also many thanks to @livingsilver94 for the testing ๐Ÿ‘

This revision was automatically updated to reflect the committed changes.

You're welcome too @Jacalz! But you didn't write my test plan, nor yours ๐Ÿ˜†

Jacalz added a comment.Feb 4 2019, 5:23 PM

Haha, you are sure right about that ๐Ÿ˜ I did basically the same that you did but on MATE and without the Python tests ๐Ÿ™‚