Page MenuHomeSolus

Update python-tqdm to 4.31.1

Authored by xulongwu4 on Feb 3 2019, 5:40 PM.



Update python-tqdm to 4.31.1.

Changelog for 4.31.1:

  • fix file.encoding==None and add tests
  • tidy code, update authors and tests. Add test to CI.
Test Plan

Dependency of D5254.

Diff Detail

R4440 python-tqdm
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

xulongwu4 created this revision.Feb 3 2019, 5:40 PM
xulongwu4 requested review of this revision.Feb 3 2019, 5:40 PM
DataDrake accepted this revision.Feb 9 2019, 3:24 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Feb 9 2019, 3:24 PM
Girtablulu requested changes to this revision.Feb 16 2019, 12:29 AM
Girtablulu added a subscriber: Girtablulu.

Was about landing this and saw this packages already exist inside the repo R4440, please rebase and use the software from the repo

This revision now requires changes to proceed.Feb 16 2019, 12:29 AM
xulongwu4 updated this revision to Diff 13096.Feb 16 2019, 12:44 AM

Update python-tqdm to 4.31.1

xulongwu4 retitled this revision from Initial commit of python-tqdm. to Update python-tqdm to 4.31.1.Feb 16 2019, 12:47 AM
xulongwu4 edited the summary of this revision. (Show Details)
JoshStrobl accepted this revision.Feb 16 2019, 1:01 AM
DataDrake accepted this revision.Feb 16 2019, 1:01 AM

Thanks for the quick fix!

This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2019, 1:05 AM
Closed by commit R4440:2c1f71b0f3a4: Update python-tqdm to 4.31.1 (authored by xulongwu4, committed by Girtablulu). · Explain Why
This revision was automatically updated to reflect the committed changes.