Page MenuHomeSolus

Update papirus-icon-theme to '20190203' and remove Adapta versions
ClosedPublic

Authored by Jacalz on Feb 3 2019, 9:55 AM.

Details

Summary

Adapta versions of the icon theme are not supported since the Adapta theme isn't seeing development either.

Changelogs:
Changes in '20190203' can be found here
Changes in '20190106' can be found here
Changes in '20181120' can be found here
Changes in '20181007' can be found here

Test Plan
  • Installed the new version and verified that I saw some new icons.
  • Installed Papirus-Adapta-icon-theme and verified that installing the new package switched me over to the new icons. They aren't perfect but it's better than no icons...

Diff Detail

Repository
R2298 papirus-icon-theme
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Jacalz created this revision.Feb 3 2019, 9:55 AM
Jacalz requested review of this revision.Feb 3 2019, 9:55 AM
Jacalz added inline comments.Feb 3 2019, 9:56 AM
package.yml
23

%make_install IGNORE="" didn't work and was still trying to install "ePapirus Papirus-Dark Papirus-Light"

JoshStrobl requested changes to this revision.Feb 6 2019, 5:36 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
20–22

I need a pull request to modify the distribution.xml.in and distribution.xml (which we have a script in repo_data/ to update, fyi) to solus-sc. Additionally, we need to ship index.theme files (I believe Papirus actually has them upstream) which gracefully switches existing users over to Papirus icons while still having Papirus Adapta selected (effectively it uses the Papirus icon assets instead), otherwise this will break the icons for anyone using Papirus Adapta.

This revision now requires changes to proceed.Feb 6 2019, 5:36 PM
Jacalz updated this revision to Diff 12889.Feb 6 2019, 6:05 PM
  • Add index.theme and initial preparations for it
Jacalz added inline comments.Feb 6 2019, 6:06 PM
package.yml
20–22

I have added the index.theme file from standard Papirus, but i don't know if that is the right one and I don't know where to install them :I

JoshStrobl requested changes to this revision.Feb 6 2019, 6:40 PM
JoshStrobl added inline comments.
package.yml
20–22

That isn't remotely the right way of doing it. See the official index themes here, from https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/issues/1499#issuecomment-429742903

This revision now requires changes to proceed.Feb 6 2019, 6:40 PM
Jacalz added a comment.Feb 7 2019, 4:37 PM

Okay so I have the right file but I still have no idea where to put it or how to do it. I am sorry 🙁

In D5250#84568, @Jacalz wrote:

Okay so I have the right file but I still have no idea where to put it or how to do it. I am sorry 🙁

Put it into the old Papirus-Adapta and Papirus-Adapta-Nokto paths respectively for each of the files in the link, file names should just be installed as index.theme

Jacalz updated this revision to Diff 12937.Feb 9 2019, 2:54 PM
  • Implement a sane way to switch Papirus-Adapta users over to Papirus
Jacalz edited the test plan for this revision. (Show Details)Feb 9 2019, 2:56 PM
Jacalz added a comment.Feb 9 2019, 3:05 PM

Btw, many thanks @JoshStrobl for the help 🙂

JoshStrobl accepted this revision.Feb 13 2019, 6:18 AM

Nice work, I'll land your repo_data PR, deprecate the respective packages, and land this package.

This revision is now accepted and ready to land.Feb 13 2019, 6:18 AM
This revision was automatically updated to reflect the committed changes.
Vistaus added a subscriber: Vistaus.EditedFeb 13 2019, 4:00 PM

But Adapta isn't dead, it's renamed 'Plata' and still very much actively developed: https://www.reddit.com/r/linux/comments/a46e6f/adapta_renamed_to_plata_and_now_hosted_on_gitlab/

But Adapta isn't dead, it's renamed 'Plata' and still very much actively developed: https://www.reddit.com/r/linux/comments/a46e6f/adapta_renamed_to_plata_and_now_hosted_on_gitlab/

Adapta is dead and the code is dropped from upstream papirus-icon-theme so there is no way for it to still exist here. Plata is a complete differently designed theme and doesn’t share much design wise with Adapta. Adapta is dead but Plata is very much alive.