Page MenuHomeSolus

Initial commit of python-tensorflow-serving-api
ClosedPublic

Authored by xulongwu4 on Jan 30 2019, 1:12 AM.
Tags
None
Referenced Files
F11013645: D5203.id14140.diff
Fri, Aug 4, 4:26 PM
F11006988: D5203.diff
Tue, Aug 1, 6:06 PM
F10922895: D5203.id14140.diff
Sun, Jul 9, 8:34 PM
F10915623: D5203.id12836.diff
Jul 8 2023, 7:57 AM
F10868456: D5203.diff
Jun 17 2023, 11:43 PM
F10841953: D5203.id12836.diff
Jun 10 2023, 9:36 AM
F10833942: D5203.id.diff
Jun 7 2023, 4:54 AM
F10831200: D5203.id12685.diff
Jun 5 2023, 8:23 AM

Details

Summary

Initial commit of python-tensorflow-serving-api

Test Plan

Dependency of D5202

Diff Detail

Repository
R4695 python-tensorflow-serving-api
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Remove the patch file and use the sed command since the modification is so simple.

This revision is now accepted and ready to land.Mar 29 2019, 12:35 AM
This revision was automatically updated to reflect the committed changes.

@xulongwu4 Issue during build:

+ bazel build //tensorflow_serving/tools/pip_package:build_pip_package
WARNING: The following rc files are no longer being read, please transfer their contents or import their path into one of the standard rc files:
/home/build/YPKG/root/python-tensorflow-serving-api/build/serving-1.12.0/tools/bazel.rc
file is invalid or corrupted (missing end of central directory record)
Cannot find central directory
FATAL: Failed to open Bazel as a zip file: (error: 5): Input/output error
This comment was removed by xulongwu4.

@JoshStrobl This error is caused by broken bazel build (see T7193). Even though the bazel build according to D5204 worked on my machine, the binary produced by the build server seems not to work. I am not clear at the moment what can cause the issue.

@JoshStrobl
One peculiar thing to notice is that the binary provided by the server only has a size of 0.57 M while I built it on my machine and got a binary of 107 M. This definitely indicates differences in these binaries.

@xulongwu4 Issue during build:

+ bazel build //tensorflow_serving/tools/pip_package:build_pip_package
WARNING: The following rc files are no longer being read, please transfer their contents or import their path into one of the standard rc files:
/home/build/YPKG/root/python-tensorflow-serving-api/build/serving-1.12.0/tools/bazel.rc
file is invalid or corrupted (missing end of central directory record)
Cannot find central directory
FATAL: Failed to open Bazel as a zip file: (error: 5): Input/output error

So more research shows that this is caused by stripping the bazel binary during build. And when I stripped the 107 M binary, I got a binary of 0.5 M. Thus it is reasonable to assume that stripping happened during the build on the server.

@JoshStrobl If you look at package.yml for D5204, I did set strip: no there. I am not 100% sure, but I suspect the we are still stripping for the debug symbols (because I see we have the bazel-dbginfo package). I am wondering if we can disable the production of a dbginfo package of bazel on the server and see if that fixes the issue.

@xulongwu4 Fixed and landed

Thanks for the quick fix!!!