Initial commit of plex-media-player, fixes T1803.
It also wants breakpad, but it's not necessary, I guess it is just for crash reporting.
Details
Details
- Reviewers
ikey joebonrichie - Maniphest Tasks
- T1803: plex-media-player
- Commits
- R4050:30ce81aca259: Initial commit of plex-media-player
Played several movies and tracks from my local Plex server, tested different bandwidths.
Diff Detail
Diff Detail
- Repository
- R4050 plex-media-player
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Has @ikey decided yet? It's still building fine, but unfortunately the program doesn't start anymore after building, updating to the latest 1.3.6 doesn't help. Maybe the dependencies have changed.
But no hurry, this commit is only 3 months old.
2017-09-23 17:53:07 [ ERROR ] InputLIRC.cpp @ 82 - LIRC Socket Error : QLocalSocket::ServerNotFoundError 2017-09-23 17:53:07 [ ERROR ] ComponentManager.cpp @ 49 - Failed to init component: display 2017-09-23 17:53:08 [ WARN ] SettingsSection.cpp @ 82 - Looking for value: "clientID" in section: "webclient" but it can't be found 2017-09-23 17:53:08 [ WARN ] Log.cpp @ 35 - "QQmlApplicationEngine failed to load component" 2017-09-23 17:53:08 [ WARN ] Log.cpp @ 35 - "qrc:/ui/webview.qml:6 module \"QtQuick.Controls\" is not installed\n" 2017-09-23 17:53:08 [ FATAL ] main.cpp @ 264 - Unhandled FatalException: Failed to parse application engine script.
Comment Actions
A couple of things I noticed.
Additionally, for @ikey I did some digging and if we want to build this without networking we'll have to pre package plex-web-client and put it on the server.
https://forums.plex.tv/discussion/284334/download-link-for-web-client-to-build-plex-media-player-package-on-freebsd
| package.yml | ||
|---|---|---|
| 31 | We already have CMAKE_BUILD_TYPE and CMAKE_INSTALL_PREFIX as part of our %cmake macro Are you sure you need -DQTROOT=/usr/share/qt5/ as well? | |
| 36 | This is a nitpick but could these be -Dm644 instead. | |
| 37 | The icon should be installed to $installdir/usr/share/pixmaps/ not to an icon theme. | |
Comment Actions
Hey Joe, thanks for your quick reply and constructive criticism! I applied your suggestions, looks fine.
However I'm not sure about this whole Conan-thing... I have never worked with it before and even if we pre-package it we would have to use networking for the pre-package, right?
| package.yml | ||
|---|---|---|
| 31 | You were right, two of them are unnecessary. However the -DQTROOT seems necessary, building without it fails and it's also mentioned on the GitHub page:
| |
| files/plex-media-player.desktop | ||
|---|---|---|
| 10 | I had to add StartupWMClass=plexmediaplayer here to prevent duplicate icons in the gnome shell launcher when plexmediaplayer was pinned. | |
Comment Actions
Didn't have the pinning problem, but won't hurt. Still have to wait for @ikey though.