Update libva to 2.4.0
ClosedPublic
Actions

Authored by kyrios123 on Jan 26 2019, 5:49 PM.

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Commits

R1886:4014612e53b1: Update libva to 2.4.0

Summary

va_TraceSurface support for VA_FOURCC_P010
Add pointer to struct wl_interface for driver to use
(integrate) va: fix new line symbol in error message
av: avoid driver path truncation
Allow import of the DRM PRIME 2 memory type
compile: fix sign/unsign compare in va_trace.c
High Dynamic Range Tone Mapping: Add a new filter for input metadata and some comments.
Remove restrictions on vaSetDriverName()

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

Successfully build libva-utils against this package

$ vainfo
libva info: VA-API version 1.4.0
libva info: va_getDriverName() returns 0
libva info: Trying to open /usr/lib64/dri/i965_drv_video.so
libva info: Found init function __vaDriverInit_1_3
libva info: va_openDriver() returns 0
vainfo: VA-API version: 1.4 (libva 2.4.0)
vainfo: Driver version: Intel i965 driver for Intel(R) Kaby Lake - 2.3.0
...

Play some video in VLC, selecting VA-API video decoder and VA-API video decoder via DRM in Hardware Acceleration

Diff Detail

Repository

R1886 libva

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kyrios123 created this revision.Jan 26 2019, 5:49 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJan 26 2019, 5:49 PM

kyrios123 requested review of this revision.Jan 26 2019, 5:49 PM

You should verify hw accelerated video decoding is still working with mpv or vlc imo as part of the test plan, check cpu usage with software decoding and hardware decoding. Test intel with libva-intel-driver AMD with mesa and nvidia via libva-vdpau-driver

Requesting more testing per @joebonrichie's remarks.

This revision now requires changes to proceed.Jan 29 2019, 11:32 AM

Tested on intel, no problem. Volunteers can check on AMD/Nvidia.

Tested on my Nvidia GTX 1050 Ti as per joebonrichie's instructions. Hardware acceleration seems to work fine with this update in VLC (~3% CPU utilization with hardware decoding, ~8-10% without in the video I tested).

JoshStrobl accepted this revision.Feb 1 2019, 7:24 PM

This revision is now accepted and ready to land.Feb 1 2019, 7:24 PM

Closed by commit R1886:4014612e53b1: Update libva to 2.4.0 (authored by kyrios123). · Explain WhyFeb 2 2019, 1:13 PM

This revision was automatically updated to reflect the committed changes.